Bearer Authentication #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Bearer Authentication
|
Thanks, is that code copy pasted solution from https://stackoverflow.com/questions/20146557/how-to-access-bearer-authenticated-service-from-android ? If so, we have to credit the guy. Also I have to check if this doesn't break other auth methods, have you tried ? |
|
yes, the code if from "Dave G". I just adapted the calls to this project |
|
|
||
| AuthSchemeRegistry authSchemeRegistry = new AuthSchemeRegistry(); | ||
| authSchemeRegistry.register("Bearer", new BearerAuthSchemeFactory()); | ||
| context.setAttribute(ClientContext.AUTHSCHEME_REGISTRY, authSchemeRegistry); |
There was a problem hiding this comment.
I don't like this line, it means we're overriding any AUTHSCHEME_REGISTRY already contained by underlying HttpContext ? This should be enabled on-demand, not as only AuthScheme available from library
|
I'll fix the comments after merging |
smarek
added a commit
that referenced
this pull request
Nov 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started using this lib and really liked, but it was missing bearer authentication (need for my project). Added support to it.