fix(upgrade): correctly handle = bindings in @angular/upgrade (#22167)

gkalpak · vicb · commit 66383901a6fb · 2018-02-25T10:06:14.000-08:00
Previously, having a `=` binding on an upgraded components would result in setting the corresponding property to an EventEmitter function. This should only happen for `&` bindings. This commit rstrores the correct behavior. Note: The issue was only present in the dynamic version of `ngUpgrade`. The static version worked as expected. The error did not show up in tests, because in AngularJS v1.5.x a function would be serialized to an empty string in interpolations, thus making them indistinguishable from uninitialized properties (in the view). The serialization behavior changed in AngularJS v1.6.x, making the errors visible. PR Close #22167
diff --git a/packages/upgrade/src/dynamic/upgrade_ng1_adapter.ts b/packages/upgrade/src/dynamic/upgrade_ng1_adapter.ts
@@ -174,8 +174,10 @@ class UpgradeNg1ComponentAdapter implements OnInit, OnChanges, DoCheck {
     }
     for (let j = 0; j < outputs.length; j++) {
       const emitter = (this as any)[outputs[j]] = new EventEmitter<any>();
-      this.setComponentProperty(
-          outputs[j], (emitter => (value: any) => emitter.emit(value))(emitter));
+      if (this.propOuts.indexOf(outputs[j]) === -1) {
+        this.setComponentProperty(
+            outputs[j], (emitter => (value: any) => emitter.emit(value))(emitter));
+      }
     }
     for (let k = 0; k < propOuts.length; k++) {
       this.checkLastValues.push(INITIAL_VALUE);

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,10 @@ class UpgradeNg1ComponentAdapter implements OnInit, OnChanges, DoCheck {`
`174`	`174`	`}`
`175`	`175`	`for (let j = 0; j < outputs.length; j++) {`
`176`	`176`	`const emitter = (this as any)[outputs[j]] = new EventEmitter<any>();`
`177`		`- this.setComponentProperty(`
`178`		`- outputs[j], (emitter => (value: any) => emitter.emit(value))(emitter));`
	`177`	`+ if (this.propOuts.indexOf(outputs[j]) === -1) {`
	`178`	`+ this.setComponentProperty(`
	`179`	`+ outputs[j], (emitter => (value: any) => emitter.emit(value))(emitter));`
	`180`	`+ }`
`179`	`181`	`}`
`180`	`182`	`for (let k = 0; k < propOuts.length; k++) {`
`181`	`183`	`this.checkLastValues.push(INITIAL_VALUE);`