fix(bazel): improve error message for missing assets (#22096)

alexeagle · mhevery · commit c5ec8d952a5f · 2018-02-08T10:01:27.000-08:00
fixes #22095 PR Close #22096
diff --git a/packages/bazel/src/ngc-wrapped/index.ts b/packages/bazel/src/ngc-wrapped/index.ts
@@ -202,6 +202,12 @@ export function compile({allowNonHermeticReads, allDepsCompiledWithBazel = true,
       return path.resolve(bazelBin, workspaceRelative) + '.d.ts';
     };
   }
+  // Patch a property on the ngHost that allows the resourceNameToModuleName function to
+  // report better errors.
+  (ngHost as any).reportMissingResource = (resourceName: string) => {
+    console.error(`\nAsset not found:\n  ${resourceName}`);
+    console.error('Check that it\'s included in the `assets` attribute of the `ng_module` rule.\n');
+  };
 
   const emitCallback: ng.TsEmitCallback = ({
     program,
diff --git a/packages/compiler-cli/src/transformers/compiler_host.ts b/packages/compiler-cli/src/transformers/compiler_host.ts
@@ -231,7 +231,12 @@ export class TsCompilerAotCompilerTypeCheckHostAdapter implements ts.CompilerHos
     }
     const filePathWithNgResource =
         this.moduleNameToFileName(addNgResourceSuffix(resourceName), containingFile);
-    return filePathWithNgResource ? stripNgResourceSuffix(filePathWithNgResource) : null;
+    const result = filePathWithNgResource ? stripNgResourceSuffix(filePathWithNgResource) : null;
+    // Used under Bazel to report more specific error with remediation advice
+    if (!result && (this.context as any).reportMissingResource) {
+      (this.context as any).reportMissingResource(resourceName);
+    }
+    return result;
   }
 
   toSummaryFileName(fileName: string, referringSrcFileName: string): string {

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,12 @@ export class TsCompilerAotCompilerTypeCheckHostAdapter implements ts.CompilerHos`
`231`	`231`	`}`
`232`	`232`	`const filePathWithNgResource =`
`233`	`233`	`this.moduleNameToFileName(addNgResourceSuffix(resourceName), containingFile);`
`234`		`- return filePathWithNgResource ? stripNgResourceSuffix(filePathWithNgResource) : null;`
	`234`	`+ const result = filePathWithNgResource ? stripNgResourceSuffix(filePathWithNgResource) : null;`
	`235`	`+ // Used under Bazel to report more specific error with remediation advice`
	`236`	`+ if (!result && (this.context as any).reportMissingResource) {`
	`237`	`+ (this.context as any).reportMissingResource(resourceName);`
	`238`	`+ }`
	`239`	`+ return result;`
`235`	`240`	`}`
`236`	`241`
`237`	`242`	`toSummaryFileName(fileName: string, referringSrcFileName: string): string {`