-
Notifications
You must be signed in to change notification settings - Fork 26.2k
NoopZone throws errors when Zone.js is not included #23428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@robwormald , I would like to fix this one and add integration test for it. And I just created a new project with
everything work file, could you provide a reproduce repo? thank you. |
@JiaLiPassion see https://stackblitz.com/edit/angular-branw3?file=app%2Fapp.component.ts - I think this will only surface on v6+? |
@robwormald , yes, you are right, thank you for the reproduce link. |
…t Testabilitity
@robwormald , I have created a PR #23452 to fix this one, please review, thank you. |
…t Testabilitity
…t Testabilitity
…t Testabilitity
@JiaLiPassion Is there any workaround for this error while we wait for your PR to merged? |
@oliverdavidt , I believe you can define this line in
|
@JiaLiPassion That worked. Thank you. |
what should we do in angular ssr in server.ts? |
Another workaround could be:
|
does it matter where this goes on the |
@maylortaylor, you can put this code anywhere in |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
NgZone throws a
ReferenceError: Zone is not defined
error when{ ngZone: 'noop' }
is used to bootstrap a module.Expected behavior
Using the
noop
ngZone should not require Zone.js to be loaded.I believe the regression was introduced here : #16863
We should probably have some kind of integration test for this.
The text was updated successfully, but these errors were encountered: