Skip to content

Missmatch v6 aot documentation and update.angular.io 5.2 to 6.0 #23854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kukjevov opened this issue May 11, 2018 · 5 comments
Closed

Missmatch v6 aot documentation and update.angular.io 5.2 to 6.0 #23854

kukjevov opened this issue May 11, 2018 · 5 comments
Assignees
Labels
freq3: high state: needs devrel input Needs input from the Angular DevRel team type: bug/fix
Milestone

Comments

@kukjevov
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

In documentation for AOT options for preserveWhitespaces is stated As of v6, this option is false by default, which results in smaller emitted template factory, but in angular update guide on http://update.angular.io is stated Choose a value of off preserveWhitespaces in your tsconfig.json to gain the benefits of this setting while the default is still to preserve whitespace.

Which one is true?

Expected behavior

It should be same.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: 6.0.1


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@trotyl
Copy link
Contributor

trotyl commented May 11, 2018

It's a problem of Angular update guide application, the recommendations are just summary of matches from the start version to end version, there's no smart filter to ignore some of them.

The specific rule is not actually for v6.

@ngbot ngbot bot added this to the needsTriage milestone May 11, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 6, 2018
@jenniferfell
Copy link
Contributor

docsarea=updating

@jenniferfell
Copy link
Contributor

jenniferfell commented Jun 6, 2018

Confirmed that the default was changed to false for v6: #22046

https://github.com/angular/angular/blob/master/packages/compiler/src/config.ts
export function preserveWhitespacesDefault(
preserveWhitespacesOption: boolean | null, defaultSetting = false): boolean {
return preserveWhitespacesOption === null ? defaultSetting : preserveWhitespacesOption;
}

Confirmed AOT compiler options doc is correct:
https://angular.io/guide/aot-compiler#preservewhitespaces

Sounds like update.angular.io could be more clear. Thanks.

@StephenFluin
Copy link
Contributor

Clarified in angular/angular-update-guide@8e6eda5

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freq3: high state: needs devrel input Needs input from the Angular DevRel team type: bug/fix
Projects
None yet
Development

No branches or pull requests

5 participants