Skip to content

docs(animation): add plunker for sequence #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs(animation): add plunker for sequence #11775

wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Member

This is the companion PR for angular/angular.io#2425

We can remove all the hardcoded plunker links in the API docs with the new {@liveExample} tag.

We can do:

{@liveExample core/animation/ts/dsl}


Embedded mode

{@liveExample core/animation/ts/dsl embedded}

Closed:

Opened:


Not hidden but behind an img:

{@liveExample core/animation/ts/dsl embedded -img="devguide/ngmodule/final-plunker.png"}

@vicb
Copy link
Contributor

vicb commented Sep 20, 2016

Nice !

Do we have some guideline of which of those 3 versions we should use for API docs ?

edit: And should we use example or liveExample ?

@Foxandxss
Copy link
Member Author

We do not. I leave that to your team's choice. I guess we shall experiment to see which one works the better.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants