docs(aio): Added developer guide on RxJS #16452
Conversation
6a37c2e to
7d15413
Compare
1afc491 to
a481925
Compare
| }, | ||
|
|
||
| { | ||
| "url": "guide/pipes", |
There was a problem hiding this comment.
Is it intentional that pipes are added here, while they are already present above (around line 188)?
There was a problem hiding this comment.
I doubt it. Probably happened during a rebase.
There was a problem hiding this comment.
Where is the plunker? Rxjs is a complex subject and there is a lot of examples that you don't know what kind of output to expect.
Continuing on that, there are a few simple snippets that could use some comments saying what is the expected output.
I saw you named hot and cold but there is no more on it. A link would be nice.
There is a part where you give a few resources link. That is better to be at the end. To not distract people from reading your guide.
I find the first part (Observable is a function) to be too complicated.
|
|
||
|
|
||
|
|
||
| **Observables** are a programming technique for handling asynchronous and event-based values produced over time. |
There was a problem hiding this comment.
I am not sure about this sentence (disclaimer, I am a bit noobish with rxjs). Observables can be used for that, but they are much more.
Would make sense to say ...
Observables are a programming technique that can be used for handling asynchronous and event-based values procuded over time
And even so, I am not so sure :/
aio/content/guide/rxjs.md
Outdated
|
|
||
|
|
||
| **Observables** are a programming technique for handling asynchronous and event-based values produced over time. | ||
| The <a href="https://github.com/benlesh/RxJS" target="_blank" title="Reactive Extensions for Javascript (RxJS) library"> |
There was a problem hiding this comment.
Why a link to benlesh fork and not the real deal?
aio/content/guide/rxjs.md
Outdated
|
|
||
| <div class="alert is-critical"> | ||
|
|
||
| Its import to avoid incomplete operator imports. A common example is having multiple files that use Observable operators but not all files imports the operators they need. If you load the files with the necessary operators imported first and then load the other files, everything works fine. Conversely, loading the files without the imported operators first blows up because the operators aren't available on the Observable. |
There was a problem hiding this comment.
I don't understand the first sentence.
| <div> | ||
| <label>Name: </label> | ||
|
|
||
| <label>ID: </label> {{ (hero$ | async)?.name }} |
a481925 to
7fa4b70
Compare
|
You can preview 7fa4b70 at https://pr16452-7fa4b70.ngbuilds.io/. |
7fa4b70 to
84c07c9
Compare
|
You can preview 84c07c9 at https://pr16452-84c07c9.ngbuilds.io/. |
84c07c9 to
9012622
Compare
|
You can preview 9012622 at https://pr16452-9012622.ngbuilds.io/. |
9012622 to
0bb8174
Compare
|
You can preview 0bb8174 at https://pr16452-0bb8174.ngbuilds.io/. |
0bb8174 to
a705287
Compare
|
You can preview a705287 at https://pr16452-a705287.ngbuilds.io/. |
4c46d6c to
a4a1f76
Compare
|
You can preview 4c46d6c at https://pr16452-4c46d6c.ngbuilds.io/. |
|
You can preview a4a1f76 at https://pr16452-a4a1f76.ngbuilds.io/. |
a4a1f76 to
f840570
Compare
|
You can preview f840570 at https://pr16452-f840570.ngbuilds.io/. |
|
You can preview 7ab406e at https://pr16452-7ab406e.ngbuilds.io/. |
7ab406e to
bd0bad4
Compare
|
You can preview bd0bad4 at https://pr16452-bd0bad4.ngbuilds.io/. |
|
@jasonaden : Recommendation here? Has all of this been incorporated into the new doc you're working on, so this can be closed? Other next steps on this PR? Thanks. |
|
@jasonaden Can we close this as a duplicate of #21423 ? |
|
@brandonroberts what is the status of your pull request? is it still relevant? please fix conflicts if they exist |
|
@splincode this guide has been folded into the Observables guide except for the marble testing area, which will come along later. I think this can be closed. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
Developer guide on observable usage. This was migrated over from angular/angular.io#3047
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: