Skip to content

WIP feat(core): Allow configuring enabled Zones via sessionStorage #17390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP feat(core): Allow configuring enabled Zones via sessionStorage #17390

wants to merge 1 commit into from

Conversation

heathkit
Copy link
Contributor

@heathkit heathkit commented Jun 9, 2017 •
edited
Loading

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Currently, Angular will fork the long stack trace zone and other optional zones if they're loaded. There's no way to specify which zones to fork other than not including them with the application.

What is the new behavior?

When using task tracking with Testability, we might like to enable or disable the task tracking zone, regardless of whether or not it's spec is loaded. This change introduces a way to specify whether particular zones should be loaded or not by setting a flag saved in the session store.

Existing behavior is preserved - if NgZone is started with enableLongStackTrace, NgZone will be forked within that zone spec.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@heathkit heathkit mentioned this pull request Jun 16, 2017
Closed
3 tasks
@IgorMinar IgorMinar added area: core Issues related to the framework runtime state: WIP labels Jul 11, 2017
@tbosch tbosch added the feature Issue that requests a new feature label Aug 3, 2017
@heathkit heathkit force-pushed the zone-override branch 3 times, most recently from 6a36d98 to fe8324f Compare October 10, 2017 03:25
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@ocombe ocombe removed this from the Backlog milestone Jan 23, 2018
@heathkit heathkit force-pushed the zone-override branch 4 times, most recently from bb9fcb8 to bcd821d Compare March 1, 2018 16:02
@heathkit heathkit changed the title WIP feat(core): configure enabled Zones in sessionStorage feat(core): Allow configuring enabled Zones via sessionStorage Mar 1, 2018
@heathkit heathkit changed the title feat(core): Allow configuring enabled Zones via sessionStorage WIP feat(core): Allow configuring enabled Zones via sessionStorage Mar 1, 2018
@ngbot
Copy link

ngbot bot commented Mar 14, 2018

Hi @heathkit! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@heathkit
Copy link
Contributor Author

I don't think this makes sense anymore. The new features in Testability (#16863) require the task tracking zone spec to work. This PR was supposed to allow users to optionally include that zone spec, so they could only turn it on for integration testing. However, it's probably better to just have people optionally include the task tracking zone spec or not as part of their build process.

@heathkit heathkit closed this Mar 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime cla: yes feature Issue that requests a new feature state: WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heathkit @IgorMinar @ocombe @tbosch @googlebot