Skip to content

fix(animations): fix increment/decrement aliases example #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(animations): fix increment/decrement aliases example #18323

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The current example of the new :increment/:decrement aliases don't work.

What is the new behavior?

The example is working

Does this PR introduce a breaking change?

[ ] Yes
[x] No

cc @matsko I guess that's what you had in mind

@matsko matsko self-requested a review July 25, 2017 20:59
@matsko
Copy link
Contributor

matsko commented Jan 9, 2018

Thank you @cexbrayat for fixing this!

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Jan 9, 2018
@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Jan 10, 2018
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@cexbrayat @alexeagle
fix(animations): fix increment/decrement aliases example (#18323)
48c1898 
PR Close #18323
@alexeagle alexeagle closed this in d2aa8ac Jan 10, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@cexbrayat @leo6104
fix(animations): fix increment/decrement aliases example (angular#18323)
2eac8d1 
PR Close angular#18323
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsko matsko matsko approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cexbrayat @matsko @alexeagle @mhevery @googlebot