feat(forms): add default updateOn values to groups and arrays #18536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2194b86 to
b5323b2
Compare
|
You can preview 0ba8999 at https://pr18536-0ba8999.ngbuilds.io/. |
|
You can preview 2194b86 at https://pr18536-2194b86.ngbuilds.io/. |
|
You can preview b5323b2 at https://pr18536-b5323b2.ngbuilds.io/. |
tinayuangao
approved these changes
Aug 7, 2017
| dispatchEvent(input, 'input'); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(control.value).toEqual('', 'Expected value to remain unchanged until submit.'); |
There was a problem hiding this comment.
nit: Also check the value is unchanged when blurred?
|
You can preview 7231271 at https://pr18536-7231271.ngbuilds.io/. |
IgorMinar
approved these changes
Aug 8, 2017
packages/forms/src/model.ts
Outdated
| @@ -242,6 +245,10 @@ export abstract class AbstractControl { | |||
| */ | |||
| get statusChanges(): Observable<any> { return this._statusChanges; } | |||
|
|
|||
| get updateOn(): FormHooks { | |||
This commit adds support for setting default `updateOn` values
in `FormGroups` and `FormArrays`. If you set `updateOn` to
’blur’` at the group level, all child controls will default to `’blur’`,
unless the child has explicitly specified a different `updateOn` value.
```
const c = new FormGroup({
one: new FormControl()
}, {updateOn: blur});
```
It's worth noting that parent groups will always update their value and
validity immediately upon value/validity updates from children. In other
words, if a group is set to update on blur and its children are individually
set to update on change, the group will still update on change with its
children; its default value will simply not be used.
|
You can preview e4695c2 at https://pr18536-e4695c2.ngbuilds.io/. |
|
You can preview c838fe3 at https://pr18536-c838fe3.ngbuilds.io/. |
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ar#18536) This commit adds support for setting default `updateOn` values in `FormGroups` and `FormArrays`. If you set `updateOn` to ’blur’` at the group level, all child controls will default to `’blur’`, unless the child has explicitly specified a different `updateOn` value. ``` const c = new FormGroup({ one: new FormControl() }, {updateOn: blur}); ``` It's worth noting that parent groups will always update their value and validity immediately upon value/validity updates from children. In other words, if a group is set to update on blur and its children are individually set to update on change, the group will still update on change with its children; its default value will simply not be used.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
…ar#18536) This commit adds support for setting default `updateOn` values in `FormGroups` and `FormArrays`. If you set `updateOn` to ’blur’` at the group level, all child controls will default to `’blur’`, unless the child has explicitly specified a different `updateOn` value. ``` const c = new FormGroup({ one: new FormControl() }, {updateOn: blur}); ``` It's worth noting that parent groups will always update their value and validity immediately upon value/validity updates from children. In other words, if a group is set to update on blur and its children are individually set to update on change, the group will still update on change with its children; its default value will simply not be used.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ar#18536) This commit adds support for setting default `updateOn` values in `FormGroups` and `FormArrays`. If you set `updateOn` to ’blur’` at the group level, all child controls will default to `’blur’`, unless the child has explicitly specified a different `updateOn` value. ``` const c = new FormGroup({ one: new FormControl() }, {updateOn: blur}); ``` It's worth noting that parent groups will always update their value and validity immediately upon value/validity updates from children. In other words, if a group is set to update on blur and its children are individually set to update on change, the group will still update on change with its children; its default value will simply not be used.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting default
updateOnvalues inFormGroupsandFormArrays. If you setupdateOnto'blur'at the group level, all child controls will default to'blur', unless the child has explicitly specified a differentupdateOnvalue.It's worth noting that parent groups will always update their value and validity immediately upon value/validity updates from children. In other words, if a group is set to update on
blurand its children are individually set to update onchange, the group will still update on change with its children; its default value will simply not be used.Upcoming PRs will address:
See more context in #18408, #18514, and the design doc.