Skip to content

docs: AttributeDirectives guide for CLI #19771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: AttributeDirectives guide for CLI #19771

wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Oct 17, 2017 •
edited
Loading

See #19510 "CLI prose changes"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@wardbell wardbell self-assigned this Oct 17, 2017
@wardbell wardbell requested a review from Foxandxss October 17, 2017 23:48
@Foxandxss Foxandxss mentioned this pull request Oct 17, 2017
Closed
24 tasks
@mary-poppins
Copy link

You can preview 6bd2ba9 at https://pr19771-6bd2ba9.ngbuilds.io/.

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@Foxandxss Foxandxss force-pushed the clify-attr-directives branch from 6bd2ba9 to acab3c2 Compare November 2, 2017 12:38
@mary-poppins
Copy link

You can preview acab3c2 at https://pr19771-acab3c2.ngbuilds.io/.

gkalpak
gkalpak reviewed Nov 2, 2017
View reviewed changes
aio/content/guide/attribute-directives.md

Put the template in its own <code>app.component.html</code>
file that looks like this:
The `import` statement specifies an additional `ElementRef` symbol from the Angular `core` library:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the : intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • green CI

@Foxandxss Foxandxss force-pushed the clify-attr-directives branch from acab3c2 to ecdf7da Compare November 3, 2017 20:57
@mary-poppins
Copy link

You can preview ecdf7da at https://pr19771-ecdf7da.ngbuilds.io/.

@gkalpak
Copy link
Member

gkalpak commented Nov 3, 2017

CircleCI didn't find the config and runs its default commands. I tried restarting it a couple of times to no avail 😕

@jasonaden
Copy link
Contributor

@wardbell There's one outstanding comment. Also, please rebase and re-push which should fix the CI error. If it doesn't, I'll rebase locally and merge.

@Foxandxss
Copy link
Member

Sorry @jasonaden , long angular connect week. I will see what can I do.

@Foxandxss Foxandxss force-pushed the clify-attr-directives branch from ecdf7da to a29fca1 Compare November 13, 2017 09:47
@mary-poppins
Copy link

You can preview a29fca1 at https://pr19771-a29fca1.ngbuilds.io/.

@jasonaden jasonaden closed this in 75d474e Nov 14, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@wardbell @jasonaden
docs: AttributeDirectives guide for CLI (#19771)
eea2039 
PR Close #19771
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Foxandxss Foxandxss Foxandxss approved these changes

@gkalpak gkalpak gkalpak left review comments

Assignees

@wardbell wardbell

Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
7 participants
@wardbell @mary-poppins @vicb @gkalpak @jasonaden @Foxandxss @googlebot