Skip to content

docs: Bootstrapping guide prose for CLI #19777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

wardbell
Copy link
Contributor

See issue #19510.

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins
Copy link

You can preview 789dbd6 at https://pr19777-789dbd6.ngbuilds.io/.


The [setup](guide/setup) instructions produce a new project with the following minimal `AppModule`.
You'll evolve this module as your application grows.
The [**Angular CLI**](https://cli.angular.io/) produce a new project with the following minimal `AppModule`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt be better to point to the getting started?

@Foxandxss Foxandxss force-pushed the clify-bootstrapping branch from 789dbd6 to 1ff3ec5 Compare November 2, 2017 12:40
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@mary-poppins
Copy link

You can preview 1ff3ec5 at https://pr19777-1ff3ec5.ngbuilds.io/.


Your initial app has only a single module, the _root_ module.
As your app grows, you'll consider subdividing it into multiple "feature" modules,
some of which can be loaded later ("lazy loaded") if and when the user chooses
to visit those features.

When you're ready to explore these possibilities, visit the [NgModules](guide/ngmodule) guide.
When you're ready to explore these possibilities, visit the [Angular Module](guide/ngmodule) guide.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular Module --> Angular Modules


The [setup](guide/setup) instructions produce a new project with the following minimal `AppModule`.
You'll evolve this module as your application grows.
The [**Angular CLI**](https://cli.angular.io/) produce a new project with the following minimal `AppModule`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produce --> produces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love when you correct Ward 😂

<div class="l-sub-section">
Angular Modules are a way to consolidate features that belong together into discrete units.
Many features of Angular itself are organized as Angular Modules.
HTTP services are in the `HttpModule`. The router is in the `RouterModule`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpModule --> HttpClientModule(?)

@Foxandxss Foxandxss force-pushed the clify-bootstrapping branch from 1ff3ec5 to ab4b22e Compare November 2, 2017 13:55
@mary-poppins
Copy link

You can preview ab4b22e at https://pr19777-ab4b22e.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label
  • green CI

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@vicb vicb merged commit 169cedd into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@wardbell wardbell deleted the clify-bootstrapping branch December 13, 2017 00:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants