Skip to content

docs: replace my- with app- to conform to CLI selectors #19778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: replace my- with app- to conform to CLI selectors #19778

wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

See Issue #19510
Leave some behind for manual attention.
Deliberately do not change “myClick” to “appClick” in TemplateSyntax guide.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@wardbell wardbell self-assigned this Oct 18, 2017
@wardbell wardbell requested a review from Foxandxss October 18, 2017 08:53
@Foxandxss Foxandxss mentioned this pull request Oct 18, 2017
Closed
24 tasks
@mary-poppins
Copy link

You can preview da6c6f0 at https://pr19778-da6c6f0.ngbuilds.io/.

@wardbell wardbell force-pushed the clify-my-to-app branch 2 times, most recently from faed17f to 69660f3 Compare October 18, 2017 09:09
@wardbell
docs: replace my- with app- to conform to CLI
c8f5fdd 
See Issue angular#19510
Leave some behind for manual attention.
Deliberately do not change “myClick” to “appClick” in TemplateSyntax guide.
Deliberately do not change any ToH because JR is redoing those samples entirely.
@mary-poppins
Copy link

You can preview faed17f at https://pr19778-faed17f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 69660f3 at https://pr19778-69660f3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c8f5fdd at https://pr19778-c8f5fdd.ngbuilds.io/.

@Foxandxss
Copy link
Member

Better remove all the changes you did for the aot chapter here because we are deleting it in another PR

This was referenced Nov 7, 2017
Closed
Closed
@jasonaden
Copy link
Contributor

Fixes #20235

@trotyl trotyl mentioned this pull request Nov 15, 2017
Closed
@gkalpak
Copy link
Member

gkalpak commented Nov 15, 2017

Another relevant issue (still not addressed): #20447

@ngbot
Copy link

ngbot bot commented Jan 16, 2018

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

1 similar comment
@ngbot
Copy link

ngbot bot commented Jan 16, 2018

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

@jenniferfell jenniferfell added state: community Someone from the Angular community is working on this issue or submitted this PR and removed state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 23, 2018
@jasonaden jasonaden added this to the needsTriage milestone Jan 29, 2019
@kapunahelewong kapunahelewong added effort2: days risk: medium refactoring Issue that involves refactoring or code-cleanup labels May 20, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 20, 2019
brandonroberts added a commit to brandonroberts/angular that referenced this pull request May 31, 2019
@brandonroberts
docs: update example references from "my-app" to "app-root"
aecd887 
"app" is the default prefix for CLI projects when generating components.
This updates our examples to conform that that default

Closes angular#19778
@brandonroberts brandonroberts mentioned this pull request May 31, 2019
Closed
14 tasks
@mhevery mhevery closed this in 8bedf50 Jun 3, 2019
mhevery pushed a commit that referenced this pull request Jun 3, 2019
@brandonroberts @mhevery
docs: update example references from "my-app" to "app-root" (#30789)
393529d 
"app" is the default prefix for CLI projects when generating components.
This updates our examples to conform that that default

Closes #19778

PR Close #30789
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Foxandxss Foxandxss Foxandxss approved these changes

Assignees

@wardbell wardbell

Labels
cla: yes effort2: days freq3: high refactoring Issue that involves refactoring or code-cleanup risk: medium state: community Someone from the Angular community is working on this issue or submitted this PR
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
9 participants
@wardbell @mary-poppins @Foxandxss @jasonaden @gkalpak @IgorMinar @kapunahelewong @googlebot @jenniferfell