Skip to content

docs: AOT guide for CLI #19510 #19818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2017
Merged

docs: AOT guide for CLI #19510 #19818

merged 1 commit into from
Nov 2, 2017

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Oct 20, 2017

See issue #19510

This PR includes copy of aot-compiler.md from PR #19818 (SHA ca214db) because this PR deletes ToH pt-6 files referenced by the current aot-compiler.md.
These two PRs must be coordinated. If there is a conflict, keep PR #19818 and discard this one.

PR Checklist

Please check if your PR fulfills the following requirements:

@wardbell wardbell self-assigned this Oct 20, 2017
@wardbell wardbell requested a review from Foxandxss October 20, 2017 00:18
@wardbell wardbell force-pushed the clify-aot branch 2 times, most recently from d2bc731 to ca214db Compare October 20, 2017 17:57
@wardbell wardbell requested a review from filipesilva October 20, 2017 22:44

<!--

Chuck: After reviewing your PR comment I'm still at a loss. See [comment there](https://github.com/angular/angular/pull/17712#discussion_r132025495).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

????


Here's the map for _Tour of Heroes_.
This page covered:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are doing ## Summary now in ToH

wardbell added a commit to IdeaBlade/angular that referenced this pull request Oct 28, 2017
Includes copy of aot-compiler.md from PR angular#19818 (she ca214db) because this PR deletes files referenced by the current aot-compiler.md. These PRs must be coordinated.
wardbell added a commit to IdeaBlade/angular that referenced this pull request Oct 28, 2017
Includes copy of aot-compiler.md from PR angular#19818 (SHA ca214db) because this PR deletes files referenced by the current aot-compiler.md. These PRs must be coordinated.

IF there is a conflict, keep PR angular#19818
wardbell added a commit to IdeaBlade/angular that referenced this pull request Oct 29, 2017
Includes copy of aot-compiler.md from PR angular#19818 (SHA ca214db) because this PR deletes files referenced by the current aot-compiler.md. These PRs must be coordinated.
IF there is a conflict, keep the version from PR angular#19818

Moves the global styles discussion and styles.1.css to the first tutorial
because readers of the code would see those styles online and in download.
wardbell added a commit to IdeaBlade/angular that referenced this pull request Oct 29, 2017
Includes copy of aot-compiler.md from PR angular#19818 (SHA ca214db) because this PR deletes files referenced by the current aot-compiler.md. These PRs must be coordinated.
IF there is a conflict, keep the version from PR angular#19818

Moves the global styles discussion and styles.1.css to the first tutorial
because readers of the code would see those styles online and in download.
@Foxandxss Foxandxss force-pushed the clify-aot branch 2 times, most recently from fba21b1 to 8f5a3d9 Compare November 2, 2017 12:55
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@Foxandxss
Copy link
Member

The docs style guide was using some of this images so I put them again in the docs-style-guide folder.

@mary-poppins
Copy link

You can preview 6c7c65b at https://pr19818-6c7c65b.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label
  • green CI

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@vicb vicb merged commit 7186c9c into angular:master Nov 2, 2017
vicb pushed a commit that referenced this pull request Nov 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants