Skip to content

docs(aio): update template forms to CLI #20014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs(aio): update template forms to CLI #20014

wants to merge 1 commit into from

Conversation

Foxandxss
Copy link
Member

Template forms done for #19510

@Foxandxss Foxandxss requested a review from wardbell October 30, 2017 12:05
@Foxandxss Foxandxss mentioned this pull request Oct 30, 2017
Closed
24 tasks
@mary-poppins
Copy link

You can preview c3dd375 at https://pr20014-c3dd375.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a768479 at https://pr20014-a768479.ngbuilds.io/.

wardbell
wardbell approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and urgent to get aligned with v.5
We can do more polishing later

trotyl
trotyl reviewed Nov 4, 2017
View reviewed changes
aio/content/guide/forms.md Outdated
There are only two changes.
The `template` is simply the new element tag identified by the component's `selector` property.
This displays the hero form when the application component is loaded.
Don't forget to remove the `name` field from the class body aswell.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aswell => as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic mistake I make. Thanks

@mary-poppins
Copy link

You can preview 864f205 at https://pr20014-864f205.ngbuilds.io/.

@ocombe ocombe added the target: patch This PR is targeted for the next patch release label Nov 13, 2017
@mary-poppins
Copy link

You can preview 56c7ab2 at https://pr20014-56c7ab2.ngbuilds.io/.

@Foxandxss Foxandxss added the action: merge The PR is ready for merge by the caretaker label Nov 13, 2017
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 13, 2017
@jasonaden jasonaden closed this in 5a2531e Nov 14, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@Foxandxss @jasonaden
docs(aio): update template forms to CLI (#20014)
dc01fb1 
PR Close #20014
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trotyl trotyl trotyl left review comments

@wardbell wardbell wardbell approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
6 participants
@Foxandxss @mary-poppins @wardbell @trotyl @ocombe @googlebot