Skip to content

docs: Update router guide to use Angular CLI #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

docs: Update router guide to use Angular CLI #20023

wants to merge 6 commits into from

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Oct 30, 2017 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Cleans up many issues with the guide

  • Conforms to Angular CLI structure w/generation commands
  • Cleans up Getting Started milestone
  • Adds complete list of router events
  • Cleans up milestone instructions
  • Adds section on routable animations
  • Various other fixes

Closes #17778, #18538, #19443, #21174, #23659, #23900, #24638, #17794

@mary-poppins
Copy link

You can preview ac326d8 at https://pr20023-ac326d8.ngbuilds.io/.

@brandonroberts brandonroberts mentioned this pull request Nov 13, 2017
Closed
3 tasks
@petebacondarwin
Copy link
Contributor

No changes to the AIO app or tooling - so removed the comp: aio label.

@IgorMinar IgorMinar added area: router action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 9, 2018
@IgorMinar
Copy link
Contributor

@jasonaden @jenniferfell this looks like a valuable change. can we schedule this for a review some time in the next sprint or so? thanks

@IgorMinar
Copy link
Contributor

@brandonroberts could you please rebase this change after we cut 6.0.0-rc.0 - don't bother doing it sooner, we are landing some cross-repo refactoring that will likely create conflicts.

@mary-poppins
Copy link

You can preview eb23253 at https://pr20023-eb23253.ngbuilds.io/.

@brandonroberts
Copy link
Contributor Author

brandonroberts commented Mar 9, 2018 •
edited
Loading

Sure @IgorMinar. Thanks for circling back on these changes to the guide.

@ngbot
Copy link

ngbot bot commented Mar 19, 2018

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@brandonroberts brandonroberts force-pushed the router-cli branch 3 times, most recently from bd5d5b3 to 903dace Compare April 4, 2018 15:03
@mary-poppins
Copy link

You can preview bd5d5b3 at https://pr20023-bd5d5b3.ngbuilds.io/.

@ngbot
Copy link

ngbot bot commented Apr 4, 2018

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@brandonroberts
Copy link
Contributor Author

@IgorMinar this branch has been rebased off the latest RC

@mary-poppins
Copy link

You can preview fa1db19 at https://pr20023-fa1db19.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4ce1479 at https://pr20023-4ce1479.ngbuilds.io/.

@jenniferfell jenniferfell added this to the v6-candidates milestone Apr 25, 2018
@jenniferfell jenniferfell mentioned this pull request Apr 25, 2018
Closed
24 tasks
@ngbot
Copy link

ngbot bot commented Apr 27, 2018

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jenniferfell jenniferfell removed this from the v6-candidates milestone May 2, 2018
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: router guide review feedback changes (#20023)
ac5aa8f 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: clean up providedIn: 'root' syntax for router examples (#20023)
0aafbac 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: add section on router integration (#20023)
a5b7008 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: update routing integration section based on feedback (#20023)
bc88f31 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: Refresh content on routable animations for router guide (#20023)
c9fece9 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: Update router guide to use Angular CLI (#20023)
1b282c2 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: router guide review feedback changes (#20023)
9c36a35 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: clean up providedIn: 'root' syntax for router examples (#20023)
0525276 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: add section on router integration (#20023)
d52dd0a 
PR Close #20023
kara pushed a commit that referenced this pull request Sep 26, 2018
@brandonroberts @kara
docs: update routing integration section based on feedback (#20023)
159e8b4 
PR Close #20023
This was referenced Sep 26, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 8, 2018
Closed
Closed
Closed
@brandonroberts brandonroberts mentioned this pull request Nov 15, 2018
Closed
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: Refresh content on routable animations for router guide (angula…
b500c1d 
…r#20023)

PR Close angular#20023
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: Update router guide to use Angular CLI (angular#20023)
f322422 
PR Close angular#20023
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: router guide review feedback changes (angular#20023)
d9dfb21 
PR Close angular#20023
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: clean up providedIn: 'root' syntax for router examples (angular…
cbccd67 
…#20023)

PR Close angular#20023
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: add section on router integration (angular#20023)
e77e839 
PR Close angular#20023
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@brandonroberts @FrederikSchlemmer
docs: update routing integration section based on feedback (angular#2…
69e4168 
…0023)

PR Close angular#20023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonaden jasonaden jasonaden approved these changes

@jbogarthyde jbogarthyde jbogarthyde approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryParamsHandling documentation
10 participants
@brandonroberts @mary-poppins @petebacondarwin @IgorMinar @jenniferfell @googlebot @adiebohi @jasonaden @jbogarthyde @gkalpak