Skip to content

build(aio): update lockfile for examples #20084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Nov 1, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

[x] Build related changes

What is the current behavior?

Installing dependencies for the docs examples fails, because the lockfile is out-of-sync with package.json.

What is the new behavior?

The docs examples lockfile is in sync with the corresponding package.json.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This was accidentally broken in #20039.

@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 1, 2017
Installing dependencies for the docs examples fails, because the
lockfile is out-of-sync with the corresponding `package.json`.
This commit brings the lockfile in sync with `package.json`.

(For reference, this was accidentally broken in angular#20039.)
@gkalpak gkalpak force-pushed the build-aio-update-lockfile branch from 221e1ad to 1a02dd8 Compare November 1, 2017 23:06
@mary-poppins
Copy link

You can preview 221e1ad at https://pr20084-221e1ad.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Nov 1, 2017
@IgorMinar IgorMinar added comp: aio target: patch This PR is targeted for the next patch release labels Nov 1, 2017
@mary-poppins
Copy link

You can preview 1a02dd8 at https://pr20084-1a02dd8.ngbuilds.io/.

IgorMinar pushed a commit that referenced this pull request Nov 1, 2017
Installing dependencies for the docs examples fails, because the
lockfile is out-of-sync with the corresponding `package.json`.
This commit brings the lockfile in sync with `package.json`.

(For reference, this was accidentally broken in #20039.)

PR Close #20084
@gkalpak
Copy link
Member Author

gkalpak commented Nov 1, 2017

Merged as b8bb2dd and c75740e.

@gkalpak gkalpak closed this Nov 1, 2017
@gkalpak gkalpak deleted the build-aio-update-lockfile branch November 1, 2017 23:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants