Skip to content

docs(aio): fix swap value #20905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs(aio): fix swap value #20905

wants to merge 1 commit into from

Conversation

A7xSV
Copy link
Contributor

@A7xSV A7xSV commented Dec 9, 2017

'http.get' has been swapped in for 'of'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Refers to swapping in 'of' for 'http.get' which is incorrect when referring to the code
Issue Number: N/A

What is the new behavior?

'http.get' in place of 'of' to reflect the changes in code

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

'http.get' has been swapped in for 'of'
@A7xSV
Copy link
Contributor Author

A7xSV commented Feb 3, 2018

Are there any more changes required ?
The docs need to reflect the changes to the code.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 5, 2018
@gkalpak
Copy link
Member

gkalpak commented Feb 5, 2018

Looks good. Thx, @A7xSV 👍

alxhub pushed a commit that referenced this pull request Feb 5, 2018
'http.get' has been swapped in for 'of'

PR Close #20905
@alxhub alxhub closed this in 3aa7e02 Feb 5, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
'http.get' has been swapped in for 'of'

PR Close angular#20905
@A7xSV A7xSV deleted the my-fix-branch branch February 27, 2018 12:28
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
'http.get' has been swapped in for 'of'

PR Close angular#20905
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants