fix(compiler): cache external reference resolution #21359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview c838585 at https://pr21359-c838585.ngbuilds.io/. |
|
You can preview cf2ebde at https://pr21359-cf2ebde.ngbuilds.io/. |
|
You can preview 8d9db53 at https://pr21359-8d9db53.ngbuilds.io/. |
Cache reference resolution for external references as finding the declaration of a symbol is expensive and does not change for a program once created. This resolves a signficant performance regression in the langauge service.
|
You can preview f78c6bc at https://pr21359-f78c6bc.ngbuilds.io/. |
alxhub
approved these changes
Jan 8, 2018
|
@chuckjaz it appears to break google3: http://test/OCL:181231159:BASE:181372032:1515535948074:d778aed |
|
The failure a flaky test. |
alexeagle
pushed a commit
that referenced
this pull request
Jan 10, 2018
Cache reference resolution for external references as finding the declaration of a symbol is expensive and does not change for a program once created. This resolves a signficant performance regression in the langauge service. PR Close #21359
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
Cache reference resolution for external references as finding the declaration of a symbol is expensive and does not change for a program once created. This resolves a signficant performance regression in the langauge service. PR Close angular#21359
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache reference resolution for external references as finding
the declaration of a symbol is expensive and does not change
for a program once created. This resolves a signficant performance
regression in the langauge service.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The language service will often take up to 600ms to handle a request, such as hover or completions, it used to take under 100ms in v4.0
What is the new behavior?
The language service now takes roughly what it used to take in v4.0.
Does this PR introduce a breaking change?