fix(compiler): make .ngsummary.json files idempotent
#21448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 3b2412c at https://pr21448-3b2412c.ngbuilds.io/. |
alxhub
reviewed
Jan 10, 2018
| @@ -382,7 +388,8 @@ export class StaticSymbolResolver { | |||
| // .ts or .d.ts, append `.ts'. Also, if it is in `node_modules`, trim the `node_module` | |||
| // location as it is not important to finding the file. | |||
| _originalFileMemo = | |||
| topLevelPath.replace(/((\.ts)|(\.d\.ts)|)$/, '.ts').replace(/^.*node_modules[/\\]/, ''); | |||
| this.host.getOutputName(topLevelPath.replace(/((\.ts)|(\.d\.ts)|)$/, '.ts') | |||
| .replace(/^.*node_modules[/\\]/, '')); | |||
There was a problem hiding this comment.
What about a file in a directory my_node_modules?
There was a problem hiding this comment.
That is not unique to the change. We should consider fixing this in a separate PR.
alxhub
approved these changes
Jan 10, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21432
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21432
Full path names are written to the
.ngsummary.jsonfile.What is the new behavior?
Relative path names are written to the
.ngsummary.jsonfile.Does this PR introduce a breaking change?