docs: update supported versions for browsers #21606

jbogarthyde · 2018-01-17T21:12:11Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

browser support versions need update

Issue Number: #19618

What is the new behavior?

Update to latest browser support, in more general terms - "latest 2 major versions"

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This phrasing requires less maintenance.

mary-poppins · 2018-01-17T21:20:32Z

You can preview e125c62 at https://pr21606-e125c62.ngbuilds.io/.

dennispbrown · 2018-01-17T21:34:18Z

aio/content/guide/browser-support.md

@@ -52,19 +52,19 @@ Angular supports most recent browsers. This includes the following specific vers
    </td>

    <td>
-      14
+      latest 2 major versions


Should the number be two or 2?

I think the shorter form is better in a table

I agree. You're right.

dennispbrown

Review summary for sample comments. This is a test.

dennispbrown · 2018-01-17T21:36:02Z

aio/content/guide/browser-support.md

@@ -88,19 +88,19 @@ Angular supports most recent browsers. This includes the following specific vers
    </td>


Great table.

thanks. no action needed.

Should Nougat and Marshmallow be separate rows? I see they are the same row in the current released doc, but I notice that all over supported versions are each given their own row.

dennispbrown · 2018-01-17T21:37:45Z

aio/content/guide/browser-support.md

    </td>

    <td>
      11
    </td>

    <td>
-      10
+      latest 2 major versions


Should we change latest to last?

mary-poppins · 2018-01-17T21:54:14Z

You can preview 92a5616 at https://pr21606-92a5616.ngbuilds.io/.

jbogarthyde · 2018-01-17T21:57:24Z

@dennispbrown All comments addressed. Ready for peer review.
@jenniferfell Ready for doc review

dennispbrown

All looks great.

googlebot · 2018-01-18T17:34:24Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

mary-poppins · 2018-01-18T17:41:35Z

You can preview 23efa05 at https://pr21606-23efa05.ngbuilds.io/.

mary-poppins · 2018-01-18T18:05:47Z

You can preview 85c3093 at https://pr21606-85c3093.ngbuilds.io/.

jbogarthyde · 2018-01-18T18:25:02Z

@dennispbrown agreed to latest change
@jenniferfell ready for approval

jenniferfell · 2018-01-22T21:12:12Z

@jbogarthyde : Please resolve issue with most recent commit message.

INVALID COMMIT MSG: "docs:minor edit"
=> ERROR: The commit message does not match the format of "(): OR revert: type(): "
Please fix the failing commit messages before continuing...
Commit message guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines

@dennispbrown recently learned how to essentially re-do a commit with a new message, so I think he can help or point you to the right recording. Thanks!

mary-poppins · 2018-01-23T18:43:09Z

You can preview bb9221b at https://pr21606-bb9221b.ngbuilds.io/.

jenniferfell

LGTM

jenniferfell · 2018-01-25T18:23:54Z

@IgorMinar Work is completed on this PR. I've reviewed and approved. When you get a chance, please review...approve...and mark for merge. Or let us know if there's anything else you want changed (@jbogarthyde) or process-stuff (me). Thanks!

IgorMinar

this one needs a bit more work

IgorMinar · 2018-01-26T23:48:27Z

aio/content/guide/browser-support.md


 But if you need an optional polyfill, you'll have to install its npm package with `npm` or `yarn`.
-For example, [if you need the web animations polyfill](http://caniuse.com/#feat=web-animation),
-you could install it with either of the following commands:
+For example, [if you need the web animations polyfill](http://caniuse.com/#feat=web-animation), you could install it with either of the following commands:

 <code-example language="sh" class="code-shell">
  npm install --save web-animations-js
  yarn add web-animations-js


this line is wrong. (it was already wrong before). it should be one or there other command depending on if the user is using npm or yarn to manage dependencies. but not both.

@jbogarthyde can you please fix this in this PR? thanks

IgorMinar · 2018-01-26T23:52:09Z

aio/content/guide/browser-support.md

@@ -350,34 +302,28 @@ Here are the features which may require additional polyfills:
  <tr style="vertical-align: top">

    <td>
-


I think all these spaces were required because if you are mixing markdown and html there needs to be a blank line between the two contexts. Because of this none of the links in this table were turned into clickable links. See: https://pr21606-bb9221b.ngbuilds.io/guide/browser-support#optional-browser-features-to-polyfill

jbogarthyde · 2018-02-01T22:33:30Z

Corrected commit comment - lacking space after "docs:"
Still seems to be failing test, however.

IgorMinar · 2018-02-01T22:56:45Z

aio/content/guide/browser-support.md

-      [Typed&nbsp;Array](guide/browser-support#typedarray)<br>
+      [Typed&nbsp;Array](guide/browser-support#typedarray)
+
+      <br>


this br should not be here. I don't think you mean to have a blank line in between the items:

IgorMinar · 2018-02-01T23:00:36Z

aio/content/guide/browser-support.md


 <code-example language="sh" class="code-shell">
  npm install --save web-animations-js
+</code-example>
+
+<code-example language="sh" class="code-shell">


I've looked at the rendered output and I think it looks confusing to list both commands like this. our readers either don't know about yarn in which case they will copy & paste the code for npm install. If they are familiar with yarn, they'll know by heart how to convert the npm command to yarn.

Therefore I suggest you remove the yarn version completely and leave only the npm version. thanks!

jenniferfell · 2018-02-01T23:28:29Z

@IgorMinar @gkalpak I looked into CircleCI lint failure and found the message below. We thought scope
was optional, but looks like we need it? Is this what's causing the failure? Otherwise, I think this is ready to mark for merge. Thanks!

Examining 3 commits between HEAD and master
INVALID COMMIT MSG: "docs:clarify npm/yarn commands, add blank lines to mix md/html in table"
=> ERROR: The commit message does not match the format of '(): ' OR 'Revert: "type(): "'

mary-poppins · 2018-02-01T23:45:53Z

You can preview 8310f7f at https://pr21606-8310f7f.ngbuilds.io/.

ngbot · 2018-02-02T06:40:55Z

I see that you just added the PR action: merge label, but the following checks are still failing:
status "ci/circleci: lint" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

IgorMinar · 2018-02-02T06:42:16Z

One of the commit messages is still invalid. There is a space missing after a colon. Can you please fix?

mary-poppins · 2018-02-02T17:19:52Z

You can preview 6f10db0 at https://pr21606-6f10db0.ngbuilds.io/.

jbogarthyde · 2018-02-02T17:56:17Z

Finally managed to fix bad commit msg

PR Close #21606

…ble (#21606) PR Close #21606

PR Close angular#21606

…ble (angular#21606) PR Close angular#21606

PR Close angular#21606

…ble (angular#21606) PR Close angular#21606

angular-automatic-lock-bot · 2019-09-13T07:21:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 17, 2018

dennispbrown reviewed Jan 17, 2018

View reviewed changes

dennispbrown suggested changes Jan 17, 2018

View reviewed changes

dennispbrown approved these changes Jan 17, 2018

View reviewed changes

chuckjaz added the comp: docs label Jan 17, 2018

googlebot added cla: no and removed cla: yes labels Jan 18, 2018

jenniferfell added the target: patch This PR is targeted for the next patch release label Jan 19, 2018

jenniferfell self-requested a review January 22, 2018 21:08

jenniferfell assigned jbogarthyde Jan 22, 2018

jbogarthyde force-pushed the jb-fix-browser-support branch 2 times, most recently from 71d9a44 to bb9221b Compare January 23, 2018 18:11

jenniferfell added cla: yes and removed cla: no labels Jan 23, 2018

jenniferfell approved these changes Jan 25, 2018

View reviewed changes

jenniferfell requested a review from IgorMinar January 25, 2018 18:22

jenniferfell added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 25, 2018

IgorMinar suggested changes Jan 26, 2018

View reviewed changes

IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 26, 2018

jenniferfell approved these changes Feb 1, 2018

View reviewed changes

IgorMinar suggested changes Feb 1, 2018

View reviewed changes

IgorMinar approved these changes Feb 2, 2018

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 2, 2018

jbogarthyde added 2 commits February 2, 2018 09:10

docs: update browser support

86c37c7

docs: clarify npm/yarn commands, add blank lines to mix md/html in table

6f10db0

jbogarthyde force-pushed the jb-fix-browser-support branch from 8310f7f to 6f10db0 Compare February 2, 2018 17:12

alxhub pushed a commit that referenced this pull request Feb 5, 2018

docs: update browser support (#21606)

cfe8393

PR Close #21606

alxhub pushed a commit that referenced this pull request Feb 5, 2018

docs: clarify npm/yarn commands, add blank lines to mix md/html in ta…

adb1d62

…ble (#21606) PR Close #21606

alxhub closed this in 1940b18 Feb 5, 2018

alxhub pushed a commit that referenced this pull request Feb 5, 2018

docs: clarify npm/yarn commands, add blank lines to mix md/html in ta…

9d3326c

…ble (#21606) PR Close #21606

jbogarthyde deleted the jb-fix-browser-support branch February 8, 2018 18:17

jbogarthyde restored the jb-fix-browser-support branch February 8, 2018 18:19

jenniferfell mentioned this pull request Feb 8, 2018

The browser support page is out of date #19618

Closed

jbogarthyde deleted the jb-fix-browser-support branch February 9, 2018 16:10

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

docs: update browser support (angular#21606)

9375182

PR Close angular#21606

jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

docs: clarify npm/yarn commands, add blank lines to mix md/html in ta…

103a555

…ble (angular#21606) PR Close angular#21606

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

docs: update browser support (angular#21606)

af6522e

PR Close angular#21606

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

docs: clarify npm/yarn commands, add blank lines to mix md/html in ta…

b0143af

…ble (angular#21606) PR Close angular#21606

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

		@@ -88,19 +88,19 @@ Angular supports most recent browsers. This includes the following specific vers
		</td>

		@@ -350,34 +302,28 @@ Here are the features which may require additional polyfills:
		<tr style="vertical-align: top">

		<td>

docs: update supported versions for browsers #21606

docs: update supported versions for browsers #21606

Conversation

jbogarthyde commented Jan 17, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

mary-poppins commented Jan 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dennispbrown left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbogarthyde Jan 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mary-poppins commented Jan 17, 2018

jbogarthyde commented Jan 17, 2018

dennispbrown left a comment

Choose a reason for hiding this comment

googlebot commented Jan 18, 2018

mary-poppins commented Jan 18, 2018

mary-poppins commented Jan 18, 2018

jbogarthyde commented Jan 18, 2018

jenniferfell commented Jan 22, 2018

mary-poppins commented Jan 23, 2018

jenniferfell left a comment

Choose a reason for hiding this comment

jenniferfell commented Jan 25, 2018

IgorMinar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbogarthyde commented Feb 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenniferfell commented Feb 1, 2018

mary-poppins commented Feb 1, 2018

ngbot bot commented Feb 2, 2018

IgorMinar commented Feb 2, 2018

mary-poppins commented Feb 2, 2018

jbogarthyde commented Feb 2, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

jbogarthyde Jan 17, 2018 •

edited

Loading

jbogarthyde commented Feb 1, 2018 •

edited

Loading