Skip to content

fix(compiler-cli): do not lower expressions in non-modules #21649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): do not lower expressions in non-modules #21649

wants to merge 1 commit into from

Conversation

chuckjaz
Copy link
Contributor

@chuckjaz chuckjaz commented Jan 18, 2018 •
edited
Loading

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue: #21651

If a compilation contains a non-module ngc might convert it into a module if it contains a expression that might be rewritten.

What is the new behavior?

Only modules are rewritten.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@chuckjaz chuckjaz force-pushed the fix-xpression-lowering-for-non-modules branch from a52662c to 50bdce9 Compare January 18, 2018 22:46
@chuckjaz chuckjaz added target: patch This PR is targeted for the next patch release area: core Issues related to the framework runtime labels Jan 18, 2018
@chuckjaz chuckjaz changed the base branch from g3 to master January 18, 2018 22:55
vicb
vicb approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue to reference ?

@chuckjaz chuckjaz force-pushed the fix-xpression-lowering-for-non-modules branch from 50bdce9 to fef715b Compare January 18, 2018 22:56
@chuckjaz chuckjaz force-pushed the fix-xpression-lowering-for-non-modules branch from fef715b to 1ca292e Compare January 18, 2018 23:01
@chuckjaz
Copy link
Contributor Author

Create Issue and update PR to reference it.

@mary-poppins
Copy link

You can preview fef715b at https://pr21649-fef715b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1ca292e at https://pr21649-1ca292e.ngbuilds.io/.

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Jan 18, 2018
mhevery pushed a commit that referenced this pull request Jan 19, 2018
@chuckjaz @mhevery
fix(compiler-cli): do not lower expressions in non-modules (#21649)
7f93aad 
Fixes: #21651

PR Close #21649
@alexeagle alexeagle closed this Jan 19, 2018
mhevery pushed a commit that referenced this pull request Jan 19, 2018
@chuckjaz @mhevery
fix(compiler-cli): do not lower expressions in non-modules (#21649)
ba4ea82 
Fixes: #21651

PR Close #21649
@chuckjaz chuckjaz mentioned this pull request Jan 22, 2018
Closed
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@chuckjaz @jbogarthyde
fix(compiler-cli): do not lower expressions in non-modules (angular#2…
2404974 
…1649)

Fixes: angular#21651

PR Close angular#21649
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@chuckjaz @leo6104
fix(compiler-cli): do not lower expressions in non-modules (angular#2…
dc9b006 
…1649)

Fixes: angular#21651

PR Close angular#21649
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chuckjaz @mary-poppins @vicb @alexeagle @googlebot