fix(common): A null value should remove the style on IE #21679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 08db567 at https://pr21679-08db567.ngbuilds.io/. |
alfaproject
suggested changes
Jan 20, 2018
| @@ -61,6 +61,19 @@ import {ComponentFixture, TestBed, async} from '@angular/core/testing'; | |||
| expectNativeEl(fixture).not.toHaveCssStyle('max-width'); | |||
| })); | |||
|
|
|||
| // https://github.com/angular/angular/issues/21064 | |||
| it('should add and remove styles which names are not dash-cased', async(() => { | |||
There was a problem hiding this comment.
Could swear it was repeated. False alarm I guess o:
IgorMinar
approved these changes
Jan 22, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 22, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21064
Kudos to @ericmartinezr for a very detailed analysis of the issue in #21064
(The added test is failing on IE without the fix)