-
Notifications
You must be signed in to change notification settings - Fork 26.3k
build(aio): generate sitemap from the generated pages #21689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can preview 186ffd7 at https://pr21689-186ffd7.ngbuilds.io/. |
30a30f1
to
99a91bc
Compare
You can preview 30a30f1 at https://pr21689-30a30f1.ngbuilds.io/. |
You can preview 99a91bc at https://pr21689-99a91bc.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with the amended version. Please squash and send out for merging. thanks!
@@ -1,3 +1,4 @@ | |||
# Allow all URLs (see http://www.robotstxt.org/robotstxt.html) | |||
User-agent: * | |||
Disallow: | |||
Sitemap: https://angular.io/generated/sitemap.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. I thought that the reference was supposed to be in the index.html. thanks for catching this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you can have a sitemap.xml
in the root which is just an index:
<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<sitemap>
<loc>https://angular.io/generated/sitemap.xml</loc>
</sitemap>
</sitemapindex>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah if you only have 1 file that is not in the root then that's good enough d:
99a91bc
to
982dad6
Compare
You can preview 982dad6 at https://pr21689-982dad6.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The sitemap is stored in the
generated
folder and is linked to from therobots.txt
file.Since we do not know the final deployment URL when running doc-gen, we leave a
@@DEPLOYMENT_HOST@@
marker, which is replaced at deployment time.Closes #21684