Skip to content

build(aio): generate sitemap from the generated pages #21689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

The sitemap is stored in the generated folder and is linked to from the robots.txt file.

Since we do not know the final deployment URL when running doc-gen, we leave a @@DEPLOYMENT_HOST@@ marker, which is replaced at deployment time.

Closes #21684

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio labels Jan 21, 2018
@mary-poppins
Copy link

You can preview 186ffd7 at https://pr21689-186ffd7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 30a30f1 at https://pr21689-30a30f1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 99a91bc at https://pr21689-99a91bc.ngbuilds.io/.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the amended version. Please squash and send out for merging. thanks!

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 22, 2018
@@ -1,3 +1,4 @@
# Allow all URLs (see http://www.robotstxt.org/robotstxt.html)
User-agent: *
Disallow:
Sitemap: https://angular.io/generated/sitemap.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting. I thought that the reference was supposed to be in the index.html. thanks for catching this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can have a sitemap.xml in the root which is just an index:

<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <sitemap>
    <loc>https://angular.io/generated/sitemap.xml</loc>
  </sitemap>
</sitemapindex>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if you only have 1 file that is not in the root then that's good enough d:

@petebacondarwin petebacondarwin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 22, 2018
@mary-poppins
Copy link

You can preview 982dad6 at https://pr21689-982dad6.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2018
@mhevery mhevery closed this in a64af40 Jan 22, 2018
@petebacondarwin petebacondarwin deleted the aio-sitemap branch January 22, 2018 22:11
mhevery pushed a commit to mhevery/angular that referenced this pull request Jan 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate sitemap for angular.io
5 participants