Skip to content

Docs. It's an unclosed <code-example> tag here. Fix #21771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Docs. It's an unclosed <code-example> tag here. Fix #21771

wants to merge 1 commit into from

Conversation

Yerkon
Copy link
Contributor

@Yerkon Yerkon commented Jan 25, 2018 •
edited by gkalpak
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Updating doc .md file

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #21769

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fixes #21769.

@Yerkon Yerkon mentioned this pull request Jan 25, 2018
Closed
@Yerkon
Copy link
Contributor Author

Yerkon commented Jan 25, 2018 •
edited
Loading

When running test locally:
./test.sh node
Output is:

Creating packages .metadata.json files...
core/src/animation/animation_metadata_wrapped.ts(8,221): error TS2307: Cannot find module './dsl'.
upgrade/static/public_api.ts(15,84): error TS2307: Cannot find module './src/common/angular1'.
upgrade/static/public_api.ts(16,34): error TS2307: Cannot find module './src/common/downgrade_component'.
upgrade/static/public_api.ts(17,35): error TS2307: Cannot find module './src/common/downgrade_injectable'.
upgrade/static/public_api.ts(18,23): error TS2307: Cannot find module './src/common/version'.
upgrade/static/public_api.ts(19,31): error TS2307: Cannot find module './src/static/downgrade_module'.
upgrade/static/public_api.ts(20,32): error TS2307: Cannot find module './src/static/upgrade_component'.
upgrade/static/public_api.ts(21,29): error TS2307: Cannot find module './src/static/upgrade_module'.

Solved

Windows 10.
Node: 8.9.4
yarn: 1.3.2
jdk-8u161-windows-x64
git version 2.10.2.windows.1

gkalpak
gkalpak approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍
(The Travis failures are not related to this PR.)

Can you please update the commit message to follow our guidelines?

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs target: patch This PR is targeted for the next patch release labels Jan 25, 2018
@Yerkon Yerkon force-pushed the docs-fix branch 2 times, most recently from e618914 to 798a655 Compare January 25, 2018 16:05
@Yerkon
Copy link
Contributor Author

Yerkon commented Jan 25, 2018 •
edited
Loading

Can you please update the commit message to follow our guidelines?

@gkalpak, Thanks. Of course. Updated.

@mary-poppins
Copy link

You can preview 6d1e4ff at https://pr21771-6d1e4ff.ngbuilds.io/.
You can preview 798a655 at https://pr21771-798a655.ngbuilds.io/.
You can preview 3a6615b at https://pr21771-3a6615b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f6182b1 at https://pr21771-f6182b1.ngbuilds.io/.

@gkalpak
Copy link
Member

gkalpak commented Jan 30, 2018 •
edited
Loading

@Yerkon, the new commit message still doesn't follow the guidelines. Can you lease change it to something like:

docs(aio): add missing closing `<code-example>` tag

@mary-poppins
Copy link

You can preview 7183fc3 at https://pr21771-7183fc3.ngbuilds.io/.

@gkalpak
Copy link
Member

gkalpak commented Jan 30, 2018

Thx for the changes, @Yerkon. Can you also rebase on master to fix the Travis failures?

@mary-poppins
Copy link

You can preview 6d49fde at https://pr21771-6d49fde.ngbuilds.io/.

@Yerkon
Copy link
Contributor Author

Yerkon commented Jan 31, 2018

Thx for the changes, @Yerkon. Can you also rebase on master to fix the Travis failures?

Done @gkalpak

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 1, 2018
@alxhub alxhub closed this in f9fa157 Feb 1, 2018
alxhub pushed a commit that referenced this pull request Feb 1, 2018
@Yerkon @alxhub
docs(aio): add missing closing <code-examle> tag (#21771)
72df747 
PR Close #21771
@Yerkon Yerkon deleted the docs-fix branch February 11, 2018 04:44
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@Yerkon @jbogarthyde
docs(aio): add missing closing <code-examle> tag (angular#21771)
b9cd68c 
PR Close angular#21771
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@Yerkon @leo6104
docs(aio): add missing closing <code-examle> tag (angular#21771)
180879c 
PR Close angular#21771
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Html styles on Angular.io
5 participants
@Yerkon @mary-poppins @gkalpak @googlebot @jenniferfell