Skip to content

fix(core): fix retrieving the binding name when an expression changes #21814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): fix retrieving the binding name when an expression changes #21814

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 26, 2018

fixes #21735
fixes #21788

blocked on fix verification (internal & external)

@vicb vicb added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Jan 26, 2018
@vicb vicb mentioned this pull request Jan 26, 2018
Closed
@mary-poppins
Copy link

You can preview 1253379 at https://pr21814-1253379.ngbuilds.io/.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked labels Jan 26, 2018
jasonaden
jasonaden previously requested changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@jasonaden jasonaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

jasonaden pushed a commit that referenced this pull request Jan 26, 2018
@vicb @jasonaden
fix(core): fix retrieving the binding name when an expression changes (…
81d64d6 
…#21814)

fixes #21735
fixes #21788

PR Close #21814
@jasonaden jasonaden dismissed their stale review January 26, 2018 23:35

it was a test

@jasonaden jasonaden closed this in 2af19c9 Jan 26, 2018
@vicb vicb deleted the 0126-bindingName branch January 27, 2018 00:09
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@vicb @jbogarthyde
fix(core): fix retrieving the binding name when an expression changes (…
1915290 
…angular#21814)

fixes angular#21735
fixes angular#21788

PR Close angular#21814
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@vicb @leo6104
fix(core): fix retrieving the binding name when an expression changes (…
033d78d 
…angular#21814)

fixes angular#21735
fixes angular#21788

PR Close angular#21814
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@jasonaden jasonaden jasonaden left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
5 participants
@vicb @mary-poppins @mhevery @jasonaden @googlebot