fix(forms): inserting and removing controls should work in re-bound f… #21822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 759439e at https://pr21822-759439e.ngbuilds.io/. |
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…orm arrays (angular#21822) Closes angular#21501 PR Close angular#21822
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…orm arrays (angular#21822) Closes angular#21501 PR Close angular#21822
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orm arrays
Closes #21501
In brief: there was a problem with calling
FormArray.removeAt()andFormArray.insert()after aFormArraywas replaced withsetControl. The collection changes calls would cause the directives to update too early, which caused form controls to be saved at the wrong offset. So on submit, some controls were not defined. Since the directives correct themselves on removal, the collection changes calls were unnecessary.