-
Notifications
You must be signed in to change notification settings - Fork 26.2k
docs: add missing underline #21892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing underline #21892
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thx 👍
The Travis failures are not related to this PR 😕 |
@gkalpak Yep~ Not sure why cannot pass the tests. |
The tests are probably related to something in master; not your PR. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Missing underline of character 'secondary' on line 104
Issue Number: N/A
What is the new behavior?
Character 'secondary' has been rendered the right way.
Does this PR introduce a breaking change?
Other information