feat(compiler-cli): reflect static methods added to classes in metadata #21926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 91d3f41 at https://pr21926-91d3f41.ngbuilds.io/. |
91d3f41 to
3c4ae2d
Compare
|
You can preview 3c4ae2d at https://pr21926-3c4ae2d.ngbuilds.io/. |
alxhub
approved these changes
Jan 31, 2018
| this.metadataCache.set(sourceFile.fileName, result); | ||
| return result; | ||
| } | ||
| } |
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Metadata does not reflect rewriting made during the transformation phase.
What is the new behavior?
The metadata for a class is augmented when a static field is injected.
Does this PR introduce a breaking change?