Skip to content

build(aio): move zip and live-example generation to yarn predocs task #21970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Feb 1, 2018

This will prevent the confusing errors for first time users who
try to generate the docs with yarn docs and are told there are
dangling links.

This does at 5 secs to the yarn docs process but it will not impact partial doc-gen speeds in yarn docs-watch and yarn serve-and-sync.

Closes #21944

This will prevent the confusing errors for first time users who
try to generate the docs with `yarn docs` and are told there are
dangling links.

Closes angular#21944
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio labels Feb 1, 2018
@mary-poppins
Copy link

You can preview 8ee9279 at https://pr21970-8ee9279.ngbuilds.io/.

@petebacondarwin petebacondarwin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 1, 2018
alxhub pushed a commit that referenced this pull request Feb 2, 2018
…sk (#21970)

This will prevent the confusing errors for first time users who
try to generate the docs with `yarn docs` and are told there are
dangling links.

Closes #21944

PR Close #21970
@alxhub alxhub closed this in 1242839 Feb 2, 2018
@petebacondarwin petebacondarwin deleted the aio-predocs branch February 2, 2018 17:39
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
…sk (angular#21970)

This will prevent the confusing errors for first time users who
try to generate the docs with `yarn docs` and are told there are
dangling links.

Closes angular#21944

PR Close angular#21970
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
…sk (angular#21970)

This will prevent the confusing errors for first time users who
try to generate the docs with `yarn docs` and are told there are
dangling links.

Closes angular#21944

PR Close angular#21970
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio: generate zips and stackblitz files in a predocs task
4 participants