Skip to content

feat(platform-browser): fix #19604, can config hammerOptions #21979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(platform-browser): fix #19604, can config hammerOptions #21979

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #19604

What is the new behavior?

Can config HammerOptions in HammerGestureConfig.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mhevery mhevery added the area: core Issues related to the framework runtime label Feb 13, 2018
@mhevery mhevery added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Feb 13, 2018
@mhevery
Copy link
Contributor

mhevery commented Feb 13, 2018

http://test/OCL:185545754:BASE:185545835:1518544803799:f622b1e5

matsko pushed a commit that referenced this pull request Feb 14, 2018
@JiaLiPassion @matsko
feat(platform-browser): fix #19604, can config hammerOptions (#21979)
fdbfd21 
PR Close #21979
@matsko matsko closed this in 1d571b2 Feb 14, 2018
vicb added a commit that referenced this pull request Feb 22, 2018
@vicb
Revert "feat(platform-browser): fix #19604, can config hammerOptions (#…
6460ac0 
…21979)"

This reverts commit fdbfd21.
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@JiaLiPassion @jbogarthyde
feat(platform-browser): fix angular#19604, can config hammerOptions (a…
627f085 
…ngular#21979)

PR Close angular#21979
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
@JiaLiPassion @smdunn809
feat(platform-browser): fix angular#19604, can config hammerOptions (a…
261f338 
…ngular#21979)

PR Close angular#21979
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@JiaLiPassion @leo6104
feat(platform-browser): fix angular#19604, can config hammerOptions (a…
ac45699 
…ngular#21979)

PR Close angular#21979
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiaLiPassion @mhevery @googlebot