fix(core): ensure initial value of QueryList length #21982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d75bf11 to
1edaafe
Compare
mhevery
approved these changes
Feb 6, 2018
Set initial value of `length` to `0`. Fixes regression introduced by angular@e544742#diff-a85dbe0991a7577ea24b49374e9ae90b where the `length` property ceased to have initial value. Closes angular#21980
1edaafe to
c085db8
Compare
|
Done |
mhevery
pushed a commit
that referenced
this pull request
Feb 7, 2018
Set initial value of `length` to `0`. Fixes regression introduced by e544742#diff-a85dbe0991a7577ea24b49374e9ae90b where the `length` property ceased to have initial value. Closes #21980 PR Close #21982
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…ngular#21982) Set initial value of `length` to `0`. Fixes regression introduced by angular@e544742#diff-a85dbe0991a7577ea24b49374e9ae90b where the `length` property ceased to have initial value. Closes angular#21980 PR Close angular#21982
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…ngular#21982) Set initial value of `length` to `0`. Fixes regression introduced by angular@e544742#diff-a85dbe0991a7577ea24b49374e9ae90b where the `length` property ceased to have initial value. Closes angular#21980 PR Close angular#21982
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21980
What is the new behavior?
Length has been initialized to
0, which would have been the initial value returned byget length()before it was refactored in e544742#diff-a85dbe0991a7577ea24b49374e9ae90b.Closes #21980.
Does this PR introduce a breaking change?
Other information