build(aio): add API static members to search index #21988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
commented
Feb 2, 2018
aio/e2e/app.e2e-spec.ts
Outdated
| expect(page.getSearchResults()).toContain('ControlValueAccessor'); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Moved to search.e2e-spec.ts
petebacondarwin
commented
Feb 2, 2018
| @@ -97,7 +97,7 @@ module.exports = function generateKeywordsProcessor(log, readFilesProcessor) { | |||
|
|
|||
| // Special case properties that contain content relating to "members" | |||
| // of a doc that represents, say, a class or interface | |||
| if (key === 'methods' || key === 'properties' || key === 'events') { | |||
| if (key === 'members' || key === 'statics') { | |||
There was a problem hiding this comment.
These keys were originally copied over from the AngularJS project.
In reality we only have members and statics on our Angular API docs.
|
You can preview 9f250ac at https://pr21988-9f250ac.ngbuilds.io/. |
gkalpak
approved these changes
Feb 2, 2018
aio/e2e/search.e2e-spec.ts
Outdated
| it('should find classes whose static method name matches the search query', () => { | ||
| page.enterSearch('compose'); | ||
| expect(page.getSearchResults()).toContain('Validators'); | ||
| }); |
There was a problem hiding this comment.
Do we need a test for members too?
There was a problem hiding this comment.
We didn't have one before :-P
9f250ac to
e101b42
Compare
|
You can preview e101b42 at https://pr21988-e101b42.ngbuilds.io/. |
|
Added an e2e test for instance members too. |
Previously searching for `compose` did not include `Validators` in the search results because we were not including all the `static` members of API docs in the index.
e101b42 to
a423c0c
Compare
|
You can preview a423c0c at https://pr21988-a423c0c.ngbuilds.io/. |
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2018
Previously searching for `compose` did not include `Validators` in the search results because we were not including all the `static` members of API docs in the index. PR Close #21988
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 22, 2018
The `search.e2e-spec.ts` file accidentally ended up in the wrong (old) directory, while rebasing angular#21988.
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
Previously searching for `compose` did not include `Validators` in the search results because we were not including all the `static` members of API docs in the index. PR Close angular#21988
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
Previously searching for `compose` did not include `Validators` in the search results because we were not including all the `static` members of API docs in the index. PR Close angular#21988
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously searching for
composedid not includeValidatorsin the search results because we were not including all the
static members in the index.