feat(core): turn whitespace removal on by default #22050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE:
The defalut value for `preserveWhitespaces` has change from `true` to `false`. In most cases this should have no impact other than smaller payload. In some circumstances it may cause the render text to be missing space between words. For example: `<span>Hello</span> <span>World</span>` would
have the whitespace removed which would render as `HelloWorld`. For this reason the change is marked as breaking.
To fix the above situation there are two options:
- Revert to preserve whitespace `@Component({preserveWhitespaces: true})`.
- Manually insert non removable space `&ngsp;` (ng-space) into template: `<span>Hello</span>&ngsp;<span>World</span>`
|
closing in favor of #22046 |
|
thank you! |
It's still open... |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
The defalut value for
preserveWhitespaceshas change fromtruetofalse. In most cases this should have no impact other than smaller payload. In some circumstances it may cause the render text to be missing space between words. For example:<span>Hello</span> <span>World</span>wouldhave the whitespace removed which would render as
HelloWorld. For this reason the change is marked as breaking.To fix the above situation there are two options:
@Component({preserveWhitespaces: true}).&ngsp;(ng-space) into template:<span>Hello</span>&ngsp;<span>World</span>PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information