fix(aio): do not rewrite /styleguide URL in Service Worker #22085
Conversation
This URL needs to be redirected via the server, so we must exclude it from being rewitten. Closes angular#22078
|
The firebase redirect was setup correctly, which you can confirm by hitting the server directly with a request for |
|
You can preview 8e1f1e3 at https://pr22085-8e1f1e3.ngbuilds.io/. |
|
@petebacondarwin This PR does not cleanly apply to |
|
It doesn't not? That's concerning. Did we forget to (mark for) cherry-pick
some PR?
…On Thu, Feb 8, 2018 at 9:48 AM Miško Hevery ***@***.***> wrote:
@petebacondarwin <https://github.com/petebacondarwin> This PR does not
cleanly apply to 5.2.x branch. Can you break it into two separate PRs,
once fro master and one for 5.2.x
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22085 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6EeCz7ksyvJl_z_zZEVPnogL1ISVks5tSzOBgaJpZM4R-AwU>
.
|
|
We never landed the original Firebase redirect fixes on stable - we were trying it on master. I am putting together a PR for that and this against stable. |
…2085) This URL needs to be redirected via the server, so we must exclude it from being rewitten. Closes angular#22078 PR Close angular#22085
…2085) This URL needs to be redirected via the server, so we must exclude it from being rewitten. Closes angular#22078 PR Close angular#22085
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This URL needs to be redirected via the server, so
we must exclude it from being rewitten.
Closes #22078