Skip to content

aio: firebase redirects (cherry picking to stable) #22104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

aio: firebase redirects (cherry picking to stable) #22104

wants to merge 5 commits into from

Conversation

petebacondarwin
Copy link
Contributor

This PR is a conflation of #21763 and #22085 against the stable branch.

@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio labels Feb 8, 2018
@mary-poppins
Copy link

You can preview 973578f at https://pr22104-973578f.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 9, 2018
mhevery pushed a commit that referenced this pull request Feb 9, 2018
@petebacondarwin @mhevery
build(aio): test Firebase hosting redirection configuration (#21763) (#…
2b67400 
…22104)

PR Close #21763

PR Close #22104
mhevery pushed a commit that referenced this pull request Feb 9, 2018
@petebacondarwin @mhevery
build(aio): test Service Worker "routing" configuration (#21763) (#22104
615bb95 
)

PR Close #21763

PR Close #22104
mhevery pushed a commit that referenced this pull request Feb 9, 2018
@petebacondarwin @mhevery
fix(aio): update Firebase redirects and SW routes (#21763) (#22104)
15ff7ba 
Closes #21377

PR Close #21763

PR Close #22104
mhevery pushed a commit that referenced this pull request Feb 9, 2018
@petebacondarwin @mhevery
docs(aio): update docs changelog with links to ts-to-js guide (#21763) (
2740b69 
#22104)

PR Close #21763

PR Close #22104
mhevery pushed a commit that referenced this pull request Feb 9, 2018
@petebacondarwin @mhevery
fix(aio): do not rewrite /styleguide URL in Service Worker (#22104)
d4a9db2 
This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes #22078

PR Close #22104
@mhevery
Copy link
Contributor

mhevery commented Feb 9, 2018

This PR does not cleanly apply to the 5.2.x branch. Please change target to master and create a separate PR for the 5.2.x branch.

@gkalpak
Copy link
Member

gkalpak commented Feb 9, 2018

@misko, it seems that the commits from this PR have already been merged into 5.2.x.

@mhevery
Copy link
Contributor

mhevery commented Feb 10, 2018

so should this PR be closed? If so can we do that?

@petebacondarwin petebacondarwin deleted the aio-firebase-redirects branch February 25, 2018 09:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes state: blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petebacondarwin @mary-poppins @mhevery @gkalpak @IgorMinar @googlebot