Skip to content

fix(animations): only use the WA-polyfill alongside AnimationBuilder #22143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(animations): only use the WA-polyfill alongside AnimationBuilder #22143

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Feb 10, 2018 •
edited
Loading

This patch removes the need to include the Web Animations API Polyfill
(web-animations-js) as a dependency. Angular will now fallback to using
CSS Keyframes in the event that element.animate is no longer supported
by the browser.

In the event that an application does use AnimationBuilder then the
web-animations-js polyfill is required to enable programmatic,
position-based access to an animation.

Closes #17496

@mary-poppins
Copy link

You can preview 2321571 at https://pr22143-2321571.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from 2321571 to 90f2fc6 Compare February 10, 2018 06:09
@mary-poppins
Copy link

You can preview 90f2fc6 at https://pr22143-90f2fc6.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch 3 times, most recently from 566e46f to 8a7f92d Compare February 13, 2018 22:11
@mary-poppins
Copy link

You can preview edade95 at https://pr22143-edade95.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from 8a7f92d to 32f98b6 Compare February 13, 2018 22:17
@mary-poppins
Copy link

You can preview 32f98b6 at https://pr22143-32f98b6.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from 32f98b6 to 1f2f9ac Compare February 13, 2018 22:43
@mary-poppins
Copy link

You can preview 1f2f9ac at https://pr22143-1f2f9ac.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from 1f2f9ac to f71d4a4 Compare February 13, 2018 23:48
@mary-poppins
Copy link

You can preview f71d4a4 at https://pr22143-f71d4a4.ngbuilds.io/.

@matsko matsko changed the title feat(animations): only use the WAA polyfill alongside AnimationBuilder fix(animations): only use the WAA polyfill alongside AnimationBuilder Feb 14, 2018
@matsko matsko force-pushed the css_keyframes_polyfill branch 3 times, most recently from bbf91b0 to 5309de2 Compare February 15, 2018 18:02
@mary-poppins
Copy link

You can preview 5309de2 at https://pr22143-5309de2.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from 5309de2 to f6342c0 Compare February 15, 2018 18:55
@mary-poppins
Copy link

You can preview f6342c0 at https://pr22143-f6342c0.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch from f6342c0 to 7ce0982 Compare February 15, 2018 23:11
@mary-poppins
Copy link

You can preview 7ce0982 at https://pr22143-7ce0982.ngbuilds.io/.

@matsko matsko force-pushed the css_keyframes_polyfill branch 3 times, most recently from 1b0917f to 13e987a Compare February 16, 2018 01:35
@mary-poppins
Copy link

You can preview e3991ad at https://pr22143-e3991ad.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1b0917f at https://pr22143-1b0917f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 13e987a at https://pr22143-13e987a.ngbuilds.io/.

This was referenced Mar 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@matsko @leo6104
fix(animations): only use the WA-polyfill alongside AnimationBuilder (a…
2ce299b 
…ngular#22143)

This patch removes the need to include the Web Animations API Polyfill
(web-animations-js) as a dependency. Angular will now fallback to using
CSS Keyframes in the event that `element.animate` is no longer supported
by the browser.

In the event that an application does use `AnimationBuilder` then the
web-animations-js polyfill is required to enable programmatic,
position-based access to an animation.

Closes angular#17496

PR Close angular#22143
@IgorMinar IgorMinar mentioned this pull request Apr 16, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Animation broken on ios7 safari 11 (ipad4-safari@browserstack)
5 participants
@matsko @mary-poppins @IgorMinar @mhevery @googlebot