fix(common): weaken AsyncPipe transform signature #22169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AsyncPipe type signature was changed to allow deferred creation of promises and observalbes that is supported by the implementation by allowing `Promise<T>|null|undefined` and by allowing `Observable<T>|null|undefined`.
vicb
approved these changes
Feb 12, 2018
|
You can preview f8d7710 at https://pr22169-f8d7710.ngbuilds.io/. |
mhevery
approved these changes
Feb 12, 2018
mhevery
pushed a commit
that referenced
this pull request
Feb 12, 2018
The AsyncPipe type signature was changed to allow deferred creation of promises and observalbes that is supported by the implementation by allowing `Promise<T>|null|undefined` and by allowing `Observable<T>|null|undefined`. PR Close #22169
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncPipe type signature was changed to allow
deferred creation of promises and observalbes that
is supported by the implementation by allowing
Promise<T>|null|undefinedand by allowingObservable<T>|null|undefined.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #22100
The type signature of AsyncPipe is too strict and causes
fullTemplateTypeCheckto report an error if the pipe is an optional property such asaddress?: Observable<Address>which is supported by the class.What is the new behavior?
The type signature of the
transformmethod now supportsObservable<T>|null|undefinedandPromise<T>|null|undefined.Does this PR introduce a breaking change?
Other information
This is not a breaking change even though it is an API change as the type signature is weaker than the prior signature and it will accept all programs that the previous signature accepted.