I tried this change and it still appears broken with AdBlock on Firefox. I no longer get an error in the console, but the app now just shows a blank screen. Works fine if I pause AdBlock.

@ssilvert thanks for checking. I'll add a note about needing to disable AdBlock and similar extensions.

BTW, this is REALLY important to us as I'm considering dynamic component loading as a major part of our architecture. We can't just tell everyone to turn off Ad Blockers.

Ah, thanks for the context, @ssilvert. Would you be so kind as to file an issue with the concern about telling people to turn off AdBlockers? We should have a thread of conversation specifically for that and having it in its own issue will help us single that point out. Please tag me in it so I can help look out for your concern.

We still want to get this PR's change in since the example needs refactoring due to the ExpressionChangedAfterItHasBeenCheckedError.

OK. There is already on open issue that led to this. I can just add to that. The thing is, this PR seems to avoid the ExpressionChangedAfterItHasBeenCheckedError, but it doesn't actually fix the problem.

I suspect that this is a general problem with dynamic component loading rather than just a problem with the example. But I hope I'm wrong.

@ssilvert ... there is important to answer also what AdBlock is doing ... how it works because it is principal for understanding what affects that behavior in fact.

@mlc-mlapis I agree. That's outside my area of expertise. Wish I could help with that.

Thanks @mlc-mlapis. @ssilvert I think AdBlock is specifically looking for the word "ad" and any thinkable combination with it. They use EasyList. It's not my area of expertise either, but I think that's what's happening. At some point, maybe we could try the example with the wording changed as an experiment, though that might be time consuming - probably something for a rewrite of that guide, which is a bigger undertaking.

EDIT: Just did a search of easy list and found 125 combinations of "AdBanner".

@jenniferfell fyi ^^

@ssilvert has legitimate concerns about AdBlock and the Dynamic Component Loader example. We should put our heads together on it and see what we can do. (@ssilvert she and I were just discussing this the other day).

@kapunahelewong You were right!!! I did a global change of everything from "ad" to "foo" and from "Ad" to "Foo". Now it works. Made my day.

@ssilvert Yay!!!! I'm so happy! Ok great, this confirms what we need to do then. Thank you very much!

fyi @jenniferfell The above conversation shows what needs to be done in Dynamic Component Loader regarding AdBlock.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}