APP_ROOT_SCOPE token #22185
Closed
APP_ROOT_SCOPE token #22185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b39c35e to
8287550
Compare
|
You can preview 8287550 at https://pr22185-8287550.ngbuilds.io/. |
mhevery
reviewed
Feb 13, 2018
| // APP_ROOT_SCOPE is cast as a Type to allow for its usage as the scope parameter of @Injectable(). | ||
|
|
||
| /** | ||
| * A scope which targets the root injector. |
There was a problem hiding this comment.
This will be part of public API and needs a richer documentation with an example.
gkalpak
reviewed
Feb 13, 2018
packages/core/src/di/scope.ts
Outdated
| * | ||
| * @experimental | ||
| */ | ||
| export const APP_ROOT_SCOPE: Type<any> = new InjectionToken<boolean>( |
There was a problem hiding this comment.
Ho, ho! Look who's back from the dead!
8287550 to
eb6fa00
Compare
|
You can preview eb6fa00 at https://pr22185-eb6fa00.ngbuilds.io/. |
eb6fa00 to
fbaf7ad
Compare
|
You can preview fbaf7ad at https://pr22185-fbaf7ad.ngbuilds.io/. |
@Injectable() supports a scope parameter which specifies the target module. However, it's still difficult to specify that a particular service belongs in the root injector. A developer attempting to ensure that must either also provide a module intended for placement in the root injector or target a module known to already be in the root injector (e.g. BrowserModule). Both of these strategies are cumbersome and brittle. Instead, this commit adds a token APP_ROOT_SCOPE which provides a straightforward way of targeting the root injector directly, without requiring special knowledge of modules within it.
fbaf7ad to
f57afca
Compare
|
You can preview f57afca at https://pr22185-f57afca.ngbuilds.io/. |
mhevery
approved these changes
Feb 14, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…lar#22185) @Injectable() supports a scope parameter which specifies the target module. However, it's still difficult to specify that a particular service belongs in the root injector. A developer attempting to ensure that must either also provide a module intended for placement in the root injector or target a module known to already be in the root injector (e.g. BrowserModule). Both of these strategies are cumbersome and brittle. Instead, this commit adds a token APP_ROOT_SCOPE which provides a straightforward way of targeting the root injector directly, without requiring special knowledge of modules within it. PR Close angular#22185
smdunn
pushed a commit
to smdunn/angular
that referenced
this pull request
Feb 28, 2018
…lar#22185) @Injectable() supports a scope parameter which specifies the target module. However, it's still difficult to specify that a particular service belongs in the root injector. A developer attempting to ensure that must either also provide a module intended for placement in the root injector or target a module known to already be in the root injector (e.g. BrowserModule). Both of these strategies are cumbersome and brittle. Instead, this commit adds a token APP_ROOT_SCOPE which provides a straightforward way of targeting the root injector directly, without requiring special knowledge of modules within it. PR Close angular#22185
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…lar#22185) @Injectable() supports a scope parameter which specifies the target module. However, it's still difficult to specify that a particular service belongs in the root injector. A developer attempting to ensure that must either also provide a module intended for placement in the root injector or target a module known to already be in the root injector (e.g. BrowserModule). Both of these strategies are cumbersome and brittle. Instead, this commit adds a token APP_ROOT_SCOPE which provides a straightforward way of targeting the root injector directly, without requiring special knowledge of modules within it. PR Close angular#22185
|
@alxhub I don't find APP_ROOT_SCOPE in the public API of core. Is this intended in favor of |
|
@SebastianM This has been redesigned: #22655 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.