fix(upgrade): correctly destroy nested downgraded component #22400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 78fe92e at https://pr22400-78fe92e.ngbuilds.io/. |
| adapter.registerCleanup(); | ||
| expect(registry.getAllTestabilities().length).toEqual(1); |
There was a problem hiding this comment.
what is the reason for moving this line?
There was a problem hiding this comment.
No reason 😁
I was trying something out and forgot to revert than part. I'll revert it.
petebacondarwin
approved these changes
Feb 23, 2018
78fe92e to
048a4f5
Compare
|
You can preview 048a4f5 at https://pr22400-048a4f5.ngbuilds.io/. |
048a4f5 to
67c5427
Compare
|
You can preview 67c5427 at https://pr22400-67c5427.ngbuilds.io/. |
Previously, when a downgraded component was destroyed in a way that did not trigger the `$destroy` event on the element (e.g. when a parent element was removed from the DOM by Angular, not AngularJS), the `ComponentRef` was not destroyed and unregistered. This commit fixes it by listening for the `$destroy` event on both the element and the scope. Fixes angular#22392
67c5427 to
2183d02
Compare
|
You can preview 2183d02 at https://pr22400-2183d02.ngbuilds.io/. |
|
Can the caretaker run a presubmit for this one please? |
alexeagle
pushed a commit
that referenced
this pull request
Feb 28, 2018
Previously, when a downgraded component was destroyed in a way that did not trigger the `$destroy` event on the element (e.g. when a parent element was removed from the DOM by Angular, not AngularJS), the `ComponentRef` was not destroyed and unregistered. This commit fixes it by listening for the `$destroy` event on both the element and the scope. Fixes #22392 PR Close #22400
smdunn
pushed a commit
to smdunn/angular
that referenced
this pull request
Feb 28, 2018
…22400) Previously, when a downgraded component was destroyed in a way that did not trigger the `$destroy` event on the element (e.g. when a parent element was removed from the DOM by Angular, not AngularJS), the `ComponentRef` was not destroyed and unregistered. This commit fixes it by listening for the `$destroy` event on both the element and the scope. Fixes angular#22392 PR Close angular#22400
This was referenced Mar 15, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…22400) Previously, when a downgraded component was destroyed in a way that did not trigger the `$destroy` event on the element (e.g. when a parent element was removed from the DOM by Angular, not AngularJS), the `ComponentRef` was not destroyed and unregistered. This commit fixes it by listening for the `$destroy` event on both the element and the scope. Fixes angular#22392 PR Close angular#22400
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
When a downgraded component is destroyed in a way that does not trigger the
$destroyevent on the element (e.g. when a parent element was removed from the DOM by Angular, not AngularJS), theComponentRefis not destroyed and unregistered.Issue Number: #22392
What is the new behavior?
Downgraded components are always correctly destroyed and unregistered.
Does this PR introduce a breaking change?
Other information
Fixes #22392.