Skip to content

feat(platform-server): bump Domino to v2.0 #22411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(platform-server): bump Domino to v2.0 #22411

wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Feb 23, 2018 •
edited
Loading

BREAKING CHANGE:

  • Bump the dependency on Domino to 2.0 to resolve issues with
    namespacing

@vikerman vikerman self-requested a review February 26, 2018 17:51
vikerman
vikerman suggested changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@vikerman vikerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow instruction at https://github.com/angular/angular/blob/master/yarn.lock.readme.md to update dependencies

@CaerusKaru
feat(platform-server): bump Domino to v2.0
f54d671 
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing
@CaerusKaru
Copy link
Member Author

@vikerman Fixed

@alexeagle alexeagle added area: server Issues related to server-side rendering area: bazel Issues related to the published `@angular/bazel` build rules and removed area: bazel Issues related to the published `@angular/bazel` build rules labels Feb 26, 2018
@vikerman vikerman requested a review from mhevery February 26, 2018 22:38
@vikerman
Copy link
Contributor

Just to clarify - There is no API breakages from Domino - but they upped their major version.

@vikerman vikerman added the target: major This PR is targeted for the next major release label Feb 26, 2018
@vikerman vikerman added the action: merge The PR is ready for merge by the caretaker label Feb 26, 2018
@alexeagle alexeagle closed this in d3827a0 Feb 26, 2018
@CaerusKaru CaerusKaru deleted the domino branch February 26, 2018 22:59
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
@CaerusKaru @smdunn809
feat(platform-server): bump Domino to v2.0 (angular#22411)
e421344 
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing

PR Close angular#22411
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@CaerusKaru @leo6104
feat(platform-server): bump Domino to v2.0 (angular#22411)
261c60b 
BREAKING CHANGE:

* Bump the dependency on Domino to 2.0 to resolve issues with
  namespacing

PR Close angular#22411
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikerman vikerman vikerman approved these changes

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CaerusKaru @vikerman @mhevery @alexeagle @googlebot