Skip to content

feat(common): export functions to format numbers, percents, currencie… #22423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(common): export functions to format numbers, percents, currencie… #22423

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 23, 2018

supersedes #22372 - fix the commit message

22372 was approved and green !

@ocombe @vicb
feat(common): export functions to format numbers, percents, currencie…
3458d80 
…s & dates

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes angular#20536
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@vicb vicb added feature Issue that requests a new feature area: common Issues related to APIs in the @angular/common package target: major This PR is targeted for the next major release labels Feb 23, 2018
@mary-poppins
Copy link

You can preview 3458d80 at https://pr22423-3458d80.ngbuilds.io/.

@vicb vicb added cla: yes action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed cla: no labels Feb 23, 2018
@ngbot
Copy link

ngbot bot commented Feb 23, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb closed this in 4180912 Feb 23, 2018
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
@ocombe @smdunn809
feat(common): export functions to format numbers, percents, currencie…
3adeb0d 
…s & dates (angular#22423)

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes angular#20536

PR Close angular#22423
@vicb vicb deleted the gh-22372 branch March 6, 2018 22:25
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@ocombe @leo6104
feat(common): export functions to format numbers, percents, currencie…
ab0c8ce 
…s & dates (angular#22423)

The utility functions `formatNumber`, `formatPercent`, `formatCurrency`, and `formatDate` used by the number, percent, currency and date pipes are now available for developers who want to use them outside of templates.

Fixes angular#20536

PR Close angular#22423
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicb @googlebot @mary-poppins @ocombe