Skip to content

build(aio): update tsc, angular, cli and other dependencies #22872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

build(aio): update tsc, angular, cli and other dependencies #22872

wants to merge 16 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar force-pushed the aio/angular-updates branch from f40f346 to 531616f Compare March 20, 2018 06:24
@IgorMinar IgorMinar added comp: aio target: major This PR is targeted for the next major release labels Mar 20, 2018
@mary-poppins
Copy link

You can preview d58f1d4 at https://pr22872-d58f1d4.ngbuilds.io/.

@IgorMinar IgorMinar changed the title build(aio): update to @angular/cli@1.7.3 build(aio): update tsc, angular, cli and other dependencies Mar 20, 2018
@mary-poppins
Copy link

You can preview 7c3e60f at https://pr22872-7c3e60f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview bc9e172 at https://pr22872-bc9e172.ngbuilds.io/.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

alfaproject
alfaproject reviewed Mar 21, 2018
View reviewed changes
aio/src/app/custom-elements/code/code.component.spec.ts Outdated
// presence of `<li>`s are a tell-tale for line numbers
await new Promise(resolve => hostComponent.codeComponent.codeFormatted.subscribe(resolve));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would codeFormatted.toPromise() work?

Copy link
Member

@gkalpak gkalpak Mar 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. AFAICT, toPromise() only resolves once the observable completes, but we just want to catch the next "emission". codeFormatted.pipe(first()).toPromise() probably would though 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup only when it completes :F

@gkalpak gkalpak force-pushed the aio/angular-updates branch 2 times, most recently from d1424d3 to 4e011af Compare March 21, 2018 13:48
@mary-poppins
Copy link

You can preview 4e011af at https://pr22872-4e011af.ngbuilds.io/.

@gkalpak gkalpak force-pushed the aio/angular-updates branch from 4e011af to d31b3f3 Compare March 21, 2018 14:45
@mary-poppins
Copy link

You can preview d31b3f3 at https://pr22872-d31b3f3.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 76fcd6e at https://pr22872-76fcd6e.ngbuilds.io/.

@gkalpak gkalpak force-pushed the aio/angular-updates branch from 76fcd6e to 6b4d938 Compare March 21, 2018 15:09
@gkalpak
Copy link
Member

gkalpak commented Mar 21, 2018 •
edited
Loading

  • Travis build for upgrading to rxjs[-compat]@6.0.0-beta.1: 356403013
  • Travis build for switching to pipeable operators: 356403557
  • Travis build for removing rxjs-compat: 356404096

Removing rxjs-compat fails due to @angular/service-worker and @angular/material.
@angular/service-worker issues should be fixed after upgrading to the latest version (#19795).
Not sure about @angular/material.

gkalpak
gkalpak approved these changes Mar 23, 2018
View reviewed changes
aio/tools/ng-packages-installer/index.js
@@ -169,7 +169,6 @@ class NgPackagesInstaller {
// FIXME: Temporarily use RxJS from root `node_modules/`.
if (peerDependencies.rxjs) {
peerDependencies.rxjs = `file:${ANGULAR_ROOT_DIR}/node_modules/rxjs`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there still local changes in angular/node_modules/rxjs/, or can we get rid of this too?

@gkalpak gkalpak mentioned this pull request Mar 23, 2018
Closed
@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 23, 2018
@matsko matsko added cla: yes and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note cla: no labels Mar 23, 2018
@matsko matsko closed this in 07e9969 Mar 23, 2018
matsko pushed a commit that referenced this pull request Mar 23, 2018
@IgorMinar @matsko
build(aio): update to @angular/core@6.0.0-beta.8 (#22872)
56e5457 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@IgorMinar @matsko
build(aio): update to typescript@2.7.2 (#22872)
328511b 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@gkalpak @matsko
build(aio): upgrade @angular/* to 6.0.0-rc.0 (#22872)
7681005 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@gkalpak @matsko
build(aio): upgrade rxjs to 6.0.0-beta.0 (#22872)
53227ab 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@gkalpak @matsko
test(aio): minor improvements (#22872)
91503e5 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@gkalpak @matsko
build(aio): upgrade rxjs to 6.0.0-beta.1 (#22872)
da76db9 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@gkalpak @matsko
refactor(aio): switch to pipeable RxJS operators (#22872)
01d2dd2 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@IgorMinar @matsko
build(aio): update examples to angular-in-memory-web-api@0.6.0 (#22872)
0f88fc7 
PR Close #22872
matsko pushed a commit that referenced this pull request Mar 23, 2018
@IgorMinar @matsko
build(aio): remove rxjs-compat dependency from examples (#22872)
3a30f5d 
we should not longer need it.

PR Close #22872
@IgorMinar IgorMinar mentioned this pull request Mar 23, 2018
Closed
34 tasks
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): update to @angular/cli@1.7.3 (angular#22872)
f2eb8fb 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): update to @angular/core@6.0.0-beta.8 (angular#22872)
efe9ace 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): update to typescript@2.7.2 (angular#22872)
28d16f1 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
build(aio): upgrade @angular/* to 6.0.0-rc.0 (angular#22872)
419c9c0 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
build(aio): upgrade rxjs to 6.0.0-beta.0 (angular#22872)
7d36aba 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
test(aio): minor improvements (angular#22872)
b01bed5 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
build(aio): upgrade rxjs to 6.0.0-beta.1 (angular#22872)
a69991d 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
refactor(aio): switch to pipeable RxJS operators (angular#22872)
0f29432 
PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): update examples to angular-in-memory-web-api@0.6.0 (angul…
49baaee 
…ar#22872)

PR Close angular#22872
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): remove rxjs-compat dependency from examples (angular#22872)
aa83753 
we should not longer need it.

PR Close angular#22872
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IgorMinar @mary-poppins @googlebot @gkalpak @alfaproject @matsko