Skip to content

feat(compiler): lower @NgModule ids if needed #23031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Mar 27, 2018

This change allows the id of an NgModule to be dynamically computed if
needed.

This change allows the id of an NgModule to be dynamically computed if
needed.
@alxhub alxhub requested a review from chuckjaz March 27, 2018 19:10
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed cla: yes labels Mar 27, 2018
@ngbot
Copy link

ngbot bot commented Mar 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "continuous-integration/travis-ci/pr"
    pending status "ci/circleci: build" is pending
    pending status "ci/circleci: lint" is pending
    pending status "code-review/pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview 8eea071 at https://pr23031-8eea071.ngbuilds.io/.

@alxhub alxhub closed this in bd024c0 Mar 28, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants