feat(platform-browser): add token marking which the type of animation… #23075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
562f106 to
ff7574e
Compare
matsko
suggested changes
Apr 4, 2018
| /** | ||
| * @experimental Animation support is experimental. | ||
| */ | ||
| export enum BrowserAnimationsModules { |
There was a problem hiding this comment.
Rename to AnimationModuleType (because it doesn't rely 100% on browser and BrowserAnimationsModules is too easy to confuse with BrowserAnimationsModule).
| * @experimental Animation support is experimental. | ||
| */ | ||
| export const BROWSER_ANIMATIONS_MODULE = | ||
| new InjectionToken<BrowserAnimationsModules>('BrowserAnimationsModule'); |
| @@ -50,12 +64,16 @@ const SHARED_ANIMATION_PROVIDERS: Provider[] = [ | |||
| */ | |||
| export const BROWSER_ANIMATIONS_PROVIDERS: Provider[] = [ | |||
| {provide: AnimationDriver, useFactory: instantiateSupportedAnimationDriver}, | |||
| {provide: BROWSER_ANIMATIONS_MODULE, useValue: BrowserAnimationsModules.BrowserAnimations}, | |||
| ...SHARED_ANIMATION_PROVIDERS | ||
| ]; | ||
|
|
||
| /** | ||
| * Separate providers from the actual module so that we can do a local modification in Google3 to | ||
| * include them in the BrowserTestingModule. | ||
| */ | ||
| export const BROWSER_NOOP_ANIMATIONS_PROVIDERS: Provider[] = | ||
| [{provide: AnimationDriver, useClass: NoopAnimationDriver}, ...SHARED_ANIMATION_PROVIDERS]; | ||
| export const BROWSER_NOOP_ANIMATIONS_PROVIDERS: Provider[] = [ |
There was a problem hiding this comment.
Could we make a test inside of https://github.com/angular/angular/blob/master/packages/core/test/animation/animation_integration_spec.ts
This way if the token is removed then we'll know if something fails in the project.
// put this at the top of the file just under the top-level describe() call...
describe('animation modules', function() {
it('should hint at BrowserAnimationsModule being used', () => {
TestBed.configureTestingModule({
declarations: [ SharedAnimationCmp ],
imports: [BrowserAnimationsModule]
});
TestBed.configureTestingModule({declarations: [SharedAnimationCmp]});
const fixture = TestBed.createComponent(Cmp);
const cmp = fixture.componentInstance;
expect(cmp.tokenValue).toEqual(...);
});
it('should hint at NoopAnimationsModule being used', () => {
TestBed.configureTestingModule({
declarations: [ SharedAnimationCmp ],
imports: [NoopAnimationsModule]
});
TestBed.configureTestingModule({declarations: [SharedAnimationCmp]});
const fixture = TestBed.createComponent(Cmp);
const cmp = fixture.componentInstance;
expect(cmp.tokenValue).toEqual(...);
});
});
class SharedAnimationCmp {
public tokenVaue;
constructor( /* inject the token */ ) {}
} c8cf07c to
2634b97
Compare
matsko
approved these changes
Apr 5, 2018
IgorMinar
suggested changes
Apr 9, 2018
| @@ -1,3 +1,12 @@ | |||
| /** @experimental */ | |||
| export declare const ANIMATION_MODULE_TYPE: InjectionToken<AnimationModuleType>; | |||
There was a problem hiding this comment.
I discussed this with @matsko.
Let's change this to ANIMATION_MODULE_NAME: InjectionToken<"BrowserAnimationsModule"|"NoopAnimationsModule">
It's simpler and exposes less of a API surface.
8e3809b to
bfa7ad2
Compare
|
You can preview 8e3809b at https://pr23075-8e3809b.ngbuilds.io/. |
bfa7ad2 to
32bca7b
Compare
|
You can preview 32bca7b at https://pr23075-32bca7b.ngbuilds.io/. |
… module nearest in the injector tree
32bca7b to
865213a
Compare
|
You can preview 865213a at https://pr23075-865213a.ngbuilds.io/. |
matsko
approved these changes
Apr 12, 2018
IgorMinar
approved these changes
Apr 12, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, it is not possible to determine if a component is running in a
BrowserAnimationsModuleorNoopAnimationsModulecontext at runtime.Issue Number: N/A
What is the new behavior?
An token is provided as a marker to be able to determine which animation context is being used for the component at runtime.
Does this PR introduce a breaking change?
Other information