fix(compiler): handle undefined annotation metadata #23349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 24928f1 at https://pr23349-24928f1.ngbuilds.io/. |
In certain cases seen in production, simplify() can returned undefined when simplifying decorator metadata. This has proven tricky to reproduce in an isolated test, but the fix is simple and low-risk: don't attempt to spread an undefined set of annotations in the first place.
|
You can preview 2893a06 at https://pr23349-2893a06.ngbuilds.io/. |
10 tasks
vicb
approved these changes
Apr 19, 2018
mhevery
approved these changes
Apr 19, 2018
|
@alxhub I changed this for master & patch please let me know if this is ok. |
vicb
pushed a commit
that referenced
this pull request
Apr 20, 2018
In certain cases seen in production, simplify() can returned undefined when simplifying decorator metadata. This has proven tricky to reproduce in an isolated test, but the fix is simple and low-risk: don't attempt to spread an undefined set of annotations in the first place. PR Close #23349
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Apr 24, 2018
This reverts commit 70e68ff. Fixed by angular/angular#23349.
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Apr 27, 2018
This reverts commit 70e68ff. Fixed by angular/angular#23349.
sis0k0
added a commit
to NativeScript/nativescript-angular
that referenced
this pull request
Apr 27, 2018
This reverts commit 70e68ff. Fixed by angular/angular#23349.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases seen in production, simplify() can returned
undefined when simplifying decorator metadata. This has proven tricky
to reproduce in an isolated test, but the fix is simple and low-risk:
don't attempt to spread an undefined set of annotations in the first
place.
Fixes #23310.