Skip to content

ci: add Brandon Roberts as an aio approver #23417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: add Brandon Roberts as an aio approver #23417

wants to merge 1 commit into from

Conversation

brandonroberts
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@brandonroberts brandonroberts force-pushed the aio-brandon-pullapprove branch from f835c01 to 7fb3141 Compare April 17, 2018 12:12
@brandonroberts brandonroberts changed the title chore(build): Add Brandon Roberts as an aio approver docs(aio): Add Brandon Roberts as an aio approver Apr 17, 2018
@IgorMinar
Copy link
Contributor

I see you using our commit message conventions slightly incorrectly.

"docs(aio)" means - documentation for the angular.io infrastructure.

"feat(aio)" or "fix(aio)" means feature or fix for angular.io infrastructure

however in this PR you want to say "ci: " because you are changing the CI configuration.

lastly, by convention we don't capitalize the first letter of the commit message (and no periods at the end), so it should be "ci: add ...".

can you please update the commit? thanks!

@IgorMinar IgorMinar self-requested a review April 17, 2018 17:11
IgorMinar
IgorMinar approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this for now. please update the commit message, and then remove the cleanup label and add the merge label. thanks!

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Apr 17, 2018
@IgorMinar
Copy link
Contributor

also keep in mind that the PR subject doesn't matter to us that much. it's nice to have them in sync, but for historical/archival purposes the commit message and content in it are much much important.

@brandonroberts brandonroberts force-pushed the aio-brandon-pullapprove branch from 7fb3141 to 4a8569c Compare April 19, 2018 04:27
@brandonroberts brandonroberts changed the title docs(aio): Add Brandon Roberts as an aio approver ci: Add Brandon Roberts as an aio approver Apr 19, 2018
@brandonroberts brandonroberts changed the title ci: Add Brandon Roberts as an aio approver ci: add Brandon Roberts as an aio approver Apr 19, 2018
@IgorMinar
Copy link
Contributor

@brandonroberts once you have all the approvals you do need to remove the "cleanup" label and add the "merge" label. otherwise your PR will remain unmerged. I'm going to do that now, but in the future please do it yourself.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 27, 2018
@ngbot
Copy link

ngbot bot commented Apr 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts
Copy link
Contributor Author

@IgorMinar ok

@IgorMinar IgorMinar closed this in 84b4593 Apr 27, 2018
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
@brandonroberts @IgorMinar
ci: add Brandon Roberts as an aio approver (#23417)
5021bdd 
PR Close #23417
IgorMinar pushed a commit that referenced this pull request Apr 27, 2018
@brandonroberts @IgorMinar
ci: add Brandon Roberts as an aio approver (#23417)
8a49ec4 
PR Close #23417
@brandonroberts brandonroberts deleted the aio-brandon-pullapprove branch April 27, 2018 18:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees

@IgorMinar IgorMinar

Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonroberts @IgorMinar @googlebot