test: add i18n to cli-hello-world integration test #23527
Conversation
7f72883 to
1ac0a9d
Compare
1ac0a9d to
b006ec9
Compare
|
I think we also need an update to |
|
There's a few stuff that needs to be updated for sure, run_test.sh tests for "hello_world__render3__cli" which doesn't exist anymore afaik. Same thing for _payload-limits.json with "hello_world__render3__rollup" and "hello_world__render3__cli" (unless they are generated somehow?). |
|
IMO this PR breaks the README so that should be fixed here - the other
tests I agree can be separate, I don't really understand the plan there.
…On Wed, Apr 25, 2018 at 6:43 AM Olivier Combe ***@***.***> wrote:
There's a few stuff that needs to be updated for sure, run_test.sh tests
for "hello_world__render3__cli" which doesn't exist anymore afaik. Same
thing for _payload-limits.json with "hello_world__render3__rollup" and
"hello_world__render3__cli" (unless they are generated somehow?).
But it should probably a different PR?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#23527 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I86dPpxwGsubw9FjhbcaK3VhpHPSks5tsH1ngaJpZM4TiNGG>
.
|
| "rxjs": "file:../../node_modules/rxjs", | ||
| "zone.js": "file:../../node_modules/zone.js" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "~0.5.0", | ||
| "@angular/cli": "^6.0.0-rc.0", | ||
| "@angular/cli": "^6.0.0-rc.5", |
There was a problem hiding this comment.
hmm we need some plan for doing this upgrade more frequently...
not in this PR :)
There was a problem hiding this comment.
the update is necessary in this PR because the fix is in rc5
|
|
||
| import { AppComponent } from './app.component'; | ||
|
|
||
| registerLocaleData(localeFr); |
There was a problem hiding this comment.
include a comment pointing to the issue so we know why this is here - otherwise seems unneeded
5fe3a3e to
121bd86
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adding a test for i18n locales to the cli hello world integration test