-
Notifications
You must be signed in to change notification settings - Fork 26.2k
docs(aio): updates doc error in guide/http #23567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates documentation to include examples for both req.flush and req.error in http testing examples.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Updates documentation to include examples for both req.flush and req.error in http testing examples. PR Close #23567
Updates documentation to include examples for both req.flush and req.error in http testing examples. PR Close #23567
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
https://angular.io/guide/http#testing-for-errors
Currently the documentation says to call
req.error
when forcing a network failure, but instead gives an example usingreq.flush
.Issue Number: #23453
What is the new behavior?
The documentation now shows two correct examples. One using
req.error
, simulating a network failure, and one usingreq.flush
, simulating a 404.Does this PR introduce a breaking change?
Other information